[SRU][O/N][PATCH v2 0/1] reenable libtraceevent

[Stefan Bader]

On 15.08.24 19:41, Bethany Jamison wrote:
> BugLink: https://bugs.launchpad.net/bugs/2076190
> 
> Reenable LIBTRACEEVENT - it was disabled in commit 92550b568d (UBUNTU:
> [Packaging] perf: build without libtraceevent) to temporarily reduce
> the amount of build dependecies. According to LP#2076190 disabling
> libtraceevent has reduced much of the functionality of perf. Perf is
> no longer able to perform any operations on tracepoints.
> 
> It looks like libtraceevent was originally disabled for no other
> reason than to reduce the number of build dependencies - and it even
> seems like this disablement was not intended to be permenent (from
> commit message: "Disable libtraceevent in perf to avoid adding extra
> build dependencies for now.") I think there is no significant tradeoff
> in reenabling libtraceevent as it is fixing a regression in
> functionality introduced by commit 92550b568d.

Ok, that is something to work with. I guess the problem is potentially 
not avoiding but reducing the dependencies. That can save setup time and 
maybe compile time. Which is something one never is completely sure what 
the initial reason was. I vaguely recall that there was talk about 
intending to package things differently. Unfortunately that is nothing I 
am following closely.
One question here, have you tried to upload source packages with the 
revert to a PPA? Why I am asking is that build dependencies are declared 
in debian/control which is generated partially from 
debian.*/debian.control.stub. If libtraceevent was disabled to avoid 
dependencies, those likely need to be added again together with the 
revert. But test compiling with cbd or our builders does not catch this 
as they work with pre-set setup.

> 
> v2: explain purpose of patch in greater detail as well as include a
> buglink

The BugLink should be in each patch. But that could be done when 
applying. Provided there is no other reason to re-submit (above).

> 
> Bethany Jamison (1):
>    UBUNTU: [Packaging] perf: reenable libtraceevent
> 
>   debian/rules.d/2-binary-arch.mk  | 4 ++--
>   debian/rules.d/3-binary-indep.mk | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
> 

- Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 48643 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240816/bf37aa73/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240816/bf37aa73/attachment-0001.sig>