NACK/Cmnt: [SRU][U/O][PATCH 1/1] wifi: rtw89: 885xb: reset IDMEM mode to prevent download firmware failure

[Kuan-Ying Lee]

On Tue, Aug 20, 2024 at 03:40:07PM +0800, En-Wei Wu wrote:
> From: Ping-Ke Shih <pkshih at realtek.com>
> 
Please provide BugLink.
> For different firmware type, it could change IDMEM mode, so reset it to
> default to avoid encountering error for RTL8851B/RTL8852B/RTL8852BT
> if that kind of firmware was downloaded before.
> 
>     rtw89_8851be 0000:02:00.0: Firmware version 0.29.41.3, cmd version 0, type 5
>     rtw89_8851be 0000:02:00.0: Firmware version 0.29.41.3, cmd version 0, type 3
>     rtw89_8851be 0000:02:00.0: MAC has already powered on
>     rtw89_8851be 0000:02:00.0: fw security fail
>     rtw89_8851be 0000:02:00.0: download firmware fail
>     rtw89_8851be 0000:02:00.0: [ERR]fwdl 0x1E0 = 0x62
>     rtw89_8851be 0000:02:00.0: [ERR]fwdl 0x83F2 = 0x8
>     rtw89_8851be 0000:02:00.0: [ERR]fw PC = 0xb892f51c
>     rtw89_8851be 0000:02:00.0: [ERR]fw PC = 0xb892f524
>     rtw89_8851be 0000:02:00.0: [ERR]fw PC = 0xb892f51c
>     rtw89_8851be 0000:02:00.0: [ERR]fw PC = 0xb892f500
>     rtw89_8851be 0000:02:00.0: [ERR]fw PC = 0xb892f51c
>     rtw89_8851be 0000:02:00.0: [ERR]fw PC = 0xb892f53c
>     rtw89_8851be 0000:02:00.0: [ERR]fw PC = 0xb892f520
>     rtw89_8851be 0000:02:00.0: [ERR]fw PC = 0xb892f520
>     rtw89_8851be 0000:02:00.0: [ERR]fw PC = 0xb892f508
>     rtw89_8851be 0000:02:00.0: [ERR]fw PC = 0xb892f534
>     rtw89_8851be 0000:02:00.0: [ERR]fw PC = 0xb892f520
>     rtw89_8851be 0000:02:00.0: [ERR]fw PC = 0xb892f534
>     rtw89_8851be 0000:02:00.0: [ERR]fw PC = 0xb892f508
>     rtw89_8851be 0000:02:00.0: [ERR]fw PC = 0xb892f53c
>     rtw89_8851be 0000:02:00.0: [ERR]fw PC = 0xb892f524
>     rtw89_8851be 0000:02:00.0: failed to setup chip information
>     rtw89_8851be: probe of 0000:02:00.0 failed with error -16
> 
> Signed-off-by: Ping-Ke Shih <pkshih at realtek.com>
> Link: https://patch.msgid.link/20240724052626.12774-4-pkshih@realtek.com
> (cherry picked from commit 80fb81bb46a57daedd5decbcc253ea48428a254e linux-next)
> Signed-off-by: En-Wei Wu <en-wei.wu at canonical.com>
> ---
>  drivers/net/wireless/realtek/rtw89/mac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c
> index e2399796aeb1..297b1d98d256 100644
> --- a/drivers/net/wireless/realtek/rtw89/mac.c
> +++ b/drivers/net/wireless/realtek/rtw89/mac.c
> @@ -3781,7 +3781,7 @@ static int rtw89_mac_enable_cpu_ax(struct rtw89_dev *rtwdev, u8 boot_reason,
>  
>  	rtw89_write32(rtwdev, R_AX_WCPU_FW_CTRL, val);
>  
> -	if (rtwdev->chip->chip_id == RTL8852B)
> +	if (rtw89_is_rtl885xb(rtwdev))
>  		rtw89_write32_mask(rtwdev, R_AX_SEC_CTRL,
>  				   B_AX_SEC_IDMEM_SIZE_CONFIG_MASK, 0x2);