[SRU] [jammy:linux-xilinx-zynqmp 13/14] serial: 8250: Document termios parameter of serial8250_em485_config()

Portia Stephens portia.stephens at canonical.com
Thu Aug 22 09:11:16 UTC 2024


From: Geert Uytterhoeven <geert+renesas at glider.be>

BugLink: https://bugs.launchpad.net/bugs/2055237

With W=1:

    drivers/tty/serial/8250/8250_port.c:679: warning: Function parameter or member 'termios' not described in 'serial8250_em485_config'

Fix this by documenting the parameter.

Fixes: ae50bb2752836277 ("serial: take termios_rwsem for ->rs485_config() & pass termios as param")
Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be>
Reviewed-by: Jiri Slaby <jirislaby at kernel.org>
Link: https://lore.kernel.org/r/2bd1e62be1d5d33333002910372feecc6d52e78f.1682071013.git.geert+renesas@glider.be
Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
(cherry picked from f16182ed9d8430adfab77f5929c23756c94b0230)
Signed-off-by: Portia Stephens <portia.stephens at canonical.com>
---
 drivers/tty/serial/8250/8250_port.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
index d7dd643661265..4b3c81e916cf9 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tty/serial/8250/8250_port.c
@@ -653,6 +653,7 @@ EXPORT_SYMBOL_GPL(serial8250_em485_destroy);
 /**
  * serial8250_em485_config() - generic ->rs485_config() callback
  * @port: uart port
+ * @termios: termios structure
  * @rs485: rs485 settings
  *
  * Generic callback usable by 8250 uart drivers to activate rs485 settings
-- 
2.34.1




More information about the kernel-team mailing list