[SRU][n:linux-azure][PATCH 0/7] Azure: backport SMB lease key fixes

Vinicius Peixoto vinicius.peixoto at canonical.com
Mon Dec 2 23:27:55 UTC 2024


BugLink: https://bugs.launchpad.net/bugs/2090880

[Impact]

Microsoft has requested for the following bugfixes to be backported into the noble:linux-azure tree:

2c7d399e551c ("smb: client: reuse file lease key in compound operations")
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2c7d399e551ccfd87bcae4ef5573097f3313d779

ffceb7640cbf ("smb: client: do not defer close open handles to deleted files")
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ffceb7640cbfe6ea60e7769e107451d63a2fe3d3

71f15c90e785 ("smb: client: retry compound request without reusing lease")
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=71f15c90e785d1de4bcd65a279e7256684c25c0d

fc20c523211a ("cifs: fixes for get_inode_info")
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fc20c523211a38b87fc850a959cb2149e4fd64b0

ec4535b2a1d7 ("smb: client: fix NULL ptr deref in cifs_mark_open_handles_for_deleted_file()")
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ec4535b2a1d709d3a1fbec26739c672f13c98a7b

f9c169b51b6c ("smb: client: fix double put of @CFILE in smb2_set_path_size()")
https://github.com/torvalds/linux/commit/f9c169b51b6ce20394594ef674d6b10efba31220

3523a3df03c6 ("smb: client: fix double put of @CFILE in smb2_rename_path()")
https://github.com/torvalds/linux/commit/3523a3df03c6f04f7ea9c2e7050102657e331a4f

[Fix]

2c7d399e551c ("smb: client: reuse file lease key in compound operations")
- cherry-pick

ffceb7640cbf ("smb: client: do not defer close open handles to deleted files")
- backported

71f15c90e785 ("smb: client: retry compound request without reusing lease")
- cherry-pick

fc20c523211a ("cifs: fixes for get_inode_info")
- cherry-pick

ec4535b2a1d7 ("smb: client: fix NULL ptr deref in cifs_mark_open_handles_for_deleted_file()")
- cherry-pick

f9c169b51b6c ("smb: client: fix double put of @CFILE in smb2_set_path_size()")
- backported

3523a3df03c6 ("smb: client: fix double put of @CFILE in smb2_rename_path()")
- cherry-pick

[Test plan]

Build and boot tested, also ran the xfstests for CIFS to ensure basic functionality was not compromised.

[Where problems could occur]

Although the changes here are somewhat self-contained, the diff is still sizeable (especially in ffceb7640cbf ("smb: client: do not defer close open handles to deleted files")), so there is a moderate regression risk. Issues here would cause hangs and/or faulty behavior in CIFS filesystems for impacted users.

[Other info]

SF #00391202

Meetakshi Setiya (4):
  smb: client: reuse file lease key in compound operations
  smb: client: do not defer close open handles to deleted files
  smb: client: retry compound request without reusing lease
  cifs: fixes for get_inode_info

Paulo Alcantara (3):
  smb: client: fix NULL ptr deref in
    cifs_mark_open_handles_for_deleted_file()
  smb: client: fix double put of @cfile in smb2_set_path_size()
  smb: client: fix double put of @cfile in smb2_rename_path()

 fs/smb/client/cifsglob.h  |   6 ++-
 fs/smb/client/cifsproto.h |  10 +++-
 fs/smb/client/cifssmb.c   |   4 +-
 fs/smb/client/file.c      |   2 +-
 fs/smb/client/inode.c     |  41 +++++++++++++---
 fs/smb/client/misc.c      |  34 +++++++++++++
 fs/smb/client/smb2inode.c | 101 +++++++++++++++++++++++++++++---------
 fs/smb/client/smb2proto.h |   6 ++-
 8 files changed, 165 insertions(+), 39 deletions(-)

-- 
2.43.0




More information about the kernel-team mailing list