ACK/Cmnt: [SRU][N][PATCH 0/2] power: intel_pstate: HWP interrupt support for maximum ratio changed

Agathe Porte agathe.porte at canonical.com
Tue Dec 3 06:49:34 UTC 2024


2024-12-02 17:29 CET, Thibault Ferrante:
> [ Impact ]
> 
>  * Performance improvement for intel hardware with dynamic HWP (Hardware P-States)
> 
> [ Fix ]
> 
> Upstream commits support dynamic HWP:
>   7ea81936b853 x86/cpufeatures: Add HWP highest perf change feature flag
>   d845cd901b28 cpufreq: intel_pstate: Support highest performance change interrupt
> 
> [ Test Plan ]
> 
>  * check on supported hardware that the correct max cpu freq is detected
> 
> [ Where problems could occur ]
> 
>  * Regression on intel CPU frequency
> 
> 
> Srinivas Pandruvada (2):
>   x86/cpufeatures: Add HWP highest perf change feature flag
>   cpufreq: intel_pstate: Support highest performance change interrupt
> 
>  arch/x86/include/asm/cpufeatures.h |  1 +
>  drivers/cpufreq/intel_pstate.c     | 23 +++++++++++++++++++----
>  2 files changed, 20 insertions(+), 4 deletions(-)

* BugLink was missing in cover letter:
  https://canonical-kernel-docs.readthedocs-hosted.com/en/latest/reference/patch_acceptance_criteria/#sru-cover-letter

* Bug should be marked "Invalid" for “linux (Ubuntu)” instead of “New”
  given the patches are upstream cherry-picks and will likely arrive
  automatically in Plucky or are already there.
  https://canonical-kernel-docs.readthedocs-hosted.com/en/latest/reference/patch_acceptance_criteria/#launchpad-bug

Other than that, LGTM.

Acked-by: Agathe Porte <agathe.porte at canonical.com>



More information about the kernel-team mailing list