[kernel-snaps-uc22][PATCH 1/1] snapcraft.yaml: add check for nvidia firmware files

[Juerg Haefliger]

On Mon, 25 Nov 2024 11:38:34 +1100
Aaron Jauregui <aaron.jauregui at canonical.com> wrote:

> BugLink: https://bugs.launchpad.net/bugs/2089509
> 
> Nvidia firmware files have sporadically gone missing in released
> pc-kernel snap revisions for an unknown reason.

The reason is now known. I've added my findings to the bug.


> Add a test to fail if
> the nvidia firmware directory does not exist to prevent incorrect builds
> from being released and to aid in finding the root cause of the issue.
> 
> Signed-off-by: Aaron Jauregui <aaron.jauregui at canonical.com>
> ---
>  snapcraft.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/snapcraft.yaml b/snapcraft.yaml
> index d4832c3..97fc296 100644
> --- a/snapcraft.yaml
> +++ b/snapcraft.yaml
> @@ -43,3 +43,6 @@ parts:
>        ls "$CRAFT_PART_INSTALL"/lib/firmware/
>        bash -eux "$CRAFT_PART_SRC"/trim-firmware "$CRAFT_PART_INSTALL"/lib
>        craftctl default
> +
> +      # Fail build if nvidia firmware is not present
> +      test -e "$CRAFT_PART_INSTALL"/lib/firmware/nvidia

I'm not opposed to such a check. In fact I think it's actually necessary
given that firmware versions can get out-of-sync. Maybe we should add an
explicit check. I.e., after building and before purging the nvidia modules,
get the exact nvidia firmware using modinfo and check at the end that
all of them are present in the install tree.

...Juerg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20241205/4d131863/attachment.sig>