[Unstable][PATCH 4/4] UBUNTU: [Packaging] rules: Remove build tests

[Juerg Haefliger]

There's a single build test from 2007... It checks for duplicate module
aliases and reports them but never fails. Huh? If we need such a test
it should probably be a SWM ABI check, so remove the local test.

Signed-off-by: Juerg Haefliger <juerg.haefliger at canonical.com>
---
 debian/rules.d/2-binary-arch.mk  | 10 +---------
 debian/tests-build/README        | 21 ---------------------
 debian/tests-build/check-aliases | 26 --------------------------
 3 files changed, 1 insertion(+), 56 deletions(-)
 delete mode 100644 debian/tests-build/README
 delete mode 100755 debian/tests-build/check-aliases

diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
index 9ed5febda358..39a2866a2c6d 100644
--- a/debian/rules.d/2-binary-arch.mk
+++ b/debian/rules.d/2-binary-arch.mk
@@ -328,15 +328,7 @@ endif
 	# Now the header scripts
 	$(call install_control,$(hdrs_pkg_name)-$*,headers,postinst)
 
-	# At the end of the package prep, call the tests
-	DPKG_ARCH="$(arch)" KERN_ARCH="$(build_arch)" FLAVOUR="$*"	\
-	 VERSION="$(abi_release)" REVISION="$(DEB_REVISION)"		\
-	 PREV_REVISION="$(prev_revision)" ABI_NUM="$(abinum)"		\
-	 PREV_ABI_NUM="$(prev_abinum)" BUILD_DIR="$(builddir)/build-$*"	\
-	 INSTALL_DIR="$(pkgdir)" SOURCE_DIR="$(CURDIR)"			\
-	 run-parts -v debian/tests-build
-
-	# Run the module signature check
+	# At the end of the package prep, run the module signature check
 	debian/scripts/checks/module-signature-check "$*" "$(pkgdir)" "$(pkgdir_ex)" $(do_skip_checks)
 
 	#
diff --git a/debian/tests-build/README b/debian/tests-build/README
deleted file mode 100644
index c74d1c4aef85..000000000000
--- a/debian/tests-build/README
+++ /dev/null
@@ -1,21 +0,0 @@
-Scripts placed in this directory get called one at a time by run-parts(8).
-The scripts are expected to perform some sort of sanity checks on the
-finished build. Scripts will be called once for each flavour.
-
-Some environment variables are exported to make life a little easier:
-
-DPKG_ARCH     : The dpkg architecture (e.g. "amd64")
-KERN_ARCH     : The kernel architecture (e.g. "x86_64")
-FLAVOUR       : The specific flavour for this run (e.g. "generic")
-VERSION       : The full version of this build (e.g. 2.6.22-1)
-REVISION      : The exact revision of this build (e.g. 1.3)
-PREV_REVISION : The revision prior to this one
-ABI_NUM       : The specific ABI number for this build (e.g. 2)
-PREV_ABI_NUM  : The previous ABI number. Can be the same as ABI_NUM.
-BUILD_DIR     : The directory where this build took place
-INSTALL_DIR   : The directory where the package is prepared
-SOURCE_DIR    : Where the main kernel source is
-
-Scripts are expected to have a zero exit status when no problems occur,
-and non-zero when an error occurs that should stop the build. Scripts
-should print whatever info they deem needed to deduce the problem.
diff --git a/debian/tests-build/check-aliases b/debian/tests-build/check-aliases
deleted file mode 100755
index ab3f23a7ec6e..000000000000
--- a/debian/tests-build/check-aliases
+++ /dev/null
@@ -1,26 +0,0 @@
-#!/usr/bin/perl -w
-
-my %map;
-
-print "Checking for dupe aliases in $ENV{'FLAVOUR'}...\n";
-
-$aliases =
-  "$ENV{'INSTALL_DIR'}/lib/modules/$ENV{'VERSION'}-$ENV{'FLAVOUR'}/modules.alias";
-
-exit 0 unless (-e $aliases);
-
-open(ALIASES, "< $aliases") or die "Could not open $aliases";
-
-while (<ALIASES>) {
-	chomp;
-	my ($junk, $alias, $module) = split;
-
-	if (defined($map{$alias})) {
-		printf("%s %20s / %-20s : %s \n", ("$map{$alias}" eq "$module")
-			? "INT" : "   ", $map{$alias}, $module, $alias);
-	} else {
-		$map{$alias} = $module;
-	}
-}
-
-exit(0);
-- 
2.43.0