ACK: [SRU] [M/N] [PATCH 0/3] Fix spurious wakeup caused by Cirque touchpad

Andrei Gherzan andrei.gherzan at canonical.com
Fri Feb 2 10:50:12 UTC 2024


On 24/02/01 11:40AM, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/2051896
> 
> [Impact]
> Spurious wakeup event caused by Cirque touchpad, prevent the system from
> sleep properly.
> 
> [Fix]
> Skip SET_POWER SLEEP so there won't be any IRQ raised by the touchpad.
> 
> [Test]
> Suspend the system 100 times and make sure non of the wakeup event is
> caused by the touchpad and its IRQ line.
> 
> [Where problems could occur]
> Logically the power consumption can increase slightly, but in reality
> there isn't any noticeable change. Since the quirk only applies to one
> device, there isn't much regression risk.
> 
> Hans de Goede (2):
>   HID: i2c-hid: Remove I2C_HID_QUIRK_SET_PWR_WAKEUP_DEV quirk
>   HID: i2c-hid: Renumber I2C_HID_QUIRK_ defines
> 
> Kai-Heng Feng (1):
>   HID: i2c-hid: Skip SET_POWER SLEEP for Cirque touchpad on system
>     suspend
> 
>  drivers/hid/hid-ids.h              |  3 +++
>  drivers/hid/i2c-hid/i2c-hid-core.c | 22 +++++++++++-----------
>  2 files changed, 14 insertions(+), 11 deletions(-)

Acked-by: Andrei Gherzan <andrei.gherzan at canonical.com>

-- 
Andrei Gherzan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240202/cea0e266/attachment-0001.sig>


More information about the kernel-team mailing list