APPLIED: [UNSTABLE][PATCH 0/2] Remove in-tree abi checks

Dimitri John Ledkov dimitri.ledkov at canonical.com
Tue Feb 6 16:59:07 UTC 2024


This patch is sort of even a no-op as all checks are disabled and skipped.
This also was previously reviewed during a hackathon.
Thus this is more or less cleaning up unused files from the status quo.

Applied to unstable.

On Fri, 2 Feb 2024 at 15:43, Dimitri John Ledkov
<dimitri.ledkov at canonical.com> wrote:
>
> linux-buildinfo packages are now externally compared by swm, with
> results approving or rejecting updates based on the stable
> tracker. Those checks also allow hints and overrides to accept
> intentional changes.
>
> Also these are done on the correct pair-wise comparisons, especially
> when two streams are being cranked.
>
> The above eliminates the need to identify previous build abi,
> download, extract it, vendor it in, and assert it at build time. And
> it is enforced for all kernels in all releases.
>
> The first patch adjusts all the debian/ scripts that do in-tree
> abi-checks. The clean target is also adjusted to remove the abi
> directory, which is committed as a second patch due to noise.
>
> Note the open script in the kteam-tools correctly will do nothing if
> abi directory is not present, thus it remains universal to kernel with
> and without abi-checks. Once we are happy with this, we can backport
> it to all jammy & focal kernels, but maybe like after the hwe ones
> roll.
>
> Dimitri John Ledkov (2):
>   UBUNTU: [Packaging] Remove in-tree abi checks
>   UBUNTU: [Packaging] drop abi files with clean
>
>  debian.master/abi/abiname                     |     1 -
>  debian.master/abi/amd64/generic               | 30498 ----------------
>  debian.master/abi/amd64/generic.compiler      |     1 -
>  debian.master/abi/amd64/generic.modules       |  6471 ----
>  .../abi/amd64/generic.modules.builtin         |   285 -
>  debian.master/abi/amd64/ignore.abi            |     1 -
>  debian.master/abi/amd64/ignore.modules        |     1 -
>  debian.master/abi/amd64/ignore.retpoline      |     1 -
>  debian.master/abi/arm64/generic               | 29404 ---------------
>  debian.master/abi/arm64/generic-64k           | 29378 ---------------
>  debian.master/abi/arm64/generic-64k.compiler  |     1 -
>  debian.master/abi/arm64/generic-64k.modules   |  7724 ----
>  .../abi/arm64/generic-64k.modules.builtin     |   545 -
>  debian.master/abi/arm64/generic.compiler      |     1 -
>  debian.master/abi/arm64/generic.modules       |  7726 ----
>  .../abi/arm64/generic.modules.builtin         |   546 -
>  debian.master/abi/arm64/ignore.abi            |     1 -
>  debian.master/abi/arm64/ignore.modules        |     1 -
>  debian.master/abi/arm64/ignore.retpoline      |     1 -
>  debian.master/abi/armhf/generic               | 27736 --------------
>  debian.master/abi/armhf/generic.compiler      |     1 -
>  debian.master/abi/armhf/generic.modules       |  7147 ----
>  .../abi/armhf/generic.modules.builtin         |   454 -
>  debian.master/abi/armhf/ignore.abi            |     1 -
>  debian.master/abi/armhf/ignore.modules        |     1 -
>  debian.master/abi/armhf/ignore.retpoline      |     1 -
>  debian.master/abi/fwinfo                      |  2327 --
>  debian.master/abi/fwinfo.builtin              |     0
>  debian.master/abi/ppc64el/generic             | 26948 --------------
>  debian.master/abi/ppc64el/generic.compiler    |     1 -
>  debian.master/abi/ppc64el/generic.modules     |  6097 ---
>  .../abi/ppc64el/generic.modules.builtin       |   263 -
>  debian.master/abi/ppc64el/ignore.abi          |     1 -
>  debian.master/abi/ppc64el/ignore.modules      |     1 -
>  debian.master/abi/ppc64el/ignore.retpoline    |     1 -
>  debian.master/abi/s390x/generic               | 14559 --------
>  debian.master/abi/s390x/generic.compiler      |     1 -
>  debian.master/abi/s390x/generic.modules       |   952 -
>  .../abi/s390x/generic.modules.builtin         |   156 -
>  debian.master/abi/s390x/ignore.abi            |     1 -
>  debian.master/abi/s390x/ignore.modules        |     1 -
>  debian.master/abi/s390x/ignore.retpoline      |     1 -
>  debian.master/abi/version                     |     1 -
>  debian/rules                                  |     8 +-
>  debian/rules.d/0-common-vars.mk               |     1 -
>  debian/rules.d/4-checks.mk                    |    14 +-
>  debian/scripts/checks/abi-check               |   139 -
>  debian/scripts/checks/final-checks            |    44 -
>  debian/scripts/checks/module-check            |   131 -
>  debian/scripts/misc/getabis                   |   222 -
>  50 files changed, 2 insertions(+), 199796 deletions(-)
>  delete mode 100644 debian.master/abi/abiname
>  delete mode 100644 debian.master/abi/amd64/generic
>  delete mode 100644 debian.master/abi/amd64/generic.compiler
>  delete mode 100644 debian.master/abi/amd64/generic.modules
>  delete mode 100644 debian.master/abi/amd64/generic.modules.builtin
>  delete mode 100644 debian.master/abi/amd64/ignore.abi
>  delete mode 100644 debian.master/abi/amd64/ignore.modules
>  delete mode 100644 debian.master/abi/amd64/ignore.retpoline
>  delete mode 100644 debian.master/abi/arm64/generic
>  delete mode 100644 debian.master/abi/arm64/generic-64k
>  delete mode 100644 debian.master/abi/arm64/generic-64k.compiler
>  delete mode 100644 debian.master/abi/arm64/generic-64k.modules
>  delete mode 100644 debian.master/abi/arm64/generic-64k.modules.builtin
>  delete mode 100644 debian.master/abi/arm64/generic.compiler
>  delete mode 100644 debian.master/abi/arm64/generic.modules
>  delete mode 100644 debian.master/abi/arm64/generic.modules.builtin
>  delete mode 100644 debian.master/abi/arm64/ignore.abi
>  delete mode 100644 debian.master/abi/arm64/ignore.modules
>  delete mode 100644 debian.master/abi/arm64/ignore.retpoline
>  delete mode 100644 debian.master/abi/armhf/generic
>  delete mode 100644 debian.master/abi/armhf/generic.compiler
>  delete mode 100644 debian.master/abi/armhf/generic.modules
>  delete mode 100644 debian.master/abi/armhf/generic.modules.builtin
>  delete mode 100644 debian.master/abi/armhf/ignore.abi
>  delete mode 100644 debian.master/abi/armhf/ignore.modules
>  delete mode 100644 debian.master/abi/armhf/ignore.retpoline
>  delete mode 100644 debian.master/abi/fwinfo
>  delete mode 100644 debian.master/abi/fwinfo.builtin
>  delete mode 100644 debian.master/abi/ppc64el/generic
>  delete mode 100644 debian.master/abi/ppc64el/generic.compiler
>  delete mode 100644 debian.master/abi/ppc64el/generic.modules
>  delete mode 100644 debian.master/abi/ppc64el/generic.modules.builtin
>  delete mode 100644 debian.master/abi/ppc64el/ignore.abi
>  delete mode 100644 debian.master/abi/ppc64el/ignore.modules
>  delete mode 100644 debian.master/abi/ppc64el/ignore.retpoline
>  delete mode 100644 debian.master/abi/s390x/generic
>  delete mode 100644 debian.master/abi/s390x/generic.compiler
>  delete mode 100644 debian.master/abi/s390x/generic.modules
>  delete mode 100644 debian.master/abi/s390x/generic.modules.builtin
>  delete mode 100644 debian.master/abi/s390x/ignore.abi
>  delete mode 100644 debian.master/abi/s390x/ignore.modules
>  delete mode 100644 debian.master/abi/s390x/ignore.retpoline
>  delete mode 100644 debian.master/abi/version
>  delete mode 100755 debian/scripts/checks/abi-check
>  delete mode 100755 debian/scripts/checks/module-check
>  delete mode 100755 debian/scripts/misc/getabis
>
> --
> 2.34.1
>


-- 
Dimitri

Sent from Ubuntu Pro
https://ubuntu.com/pro



More information about the kernel-team mailing list