APPLIED/Cmnt: [SRU][jammy][PATCH 0/1] performance: address_space: add padding for i_map and i_mmap_rwsem to mitigate a false sharing
Stefan Bader
stefan.bader at canonical.com
Mon Feb 19 13:26:38 UTC 2024
On 13.02.24 21:42, Philip Cox wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2053069
>
> SRU Justification:
>
> [Impact]
> In high core count systems such as Intel Sapphire Rapids
> (with a 112C/224T count) this this change improvesgeekbench performance by
> ~5.3% due to moving the elements in the address_space struct.
>
> [Fix]
> by moving i_mmap_rwsema, vma_interval_tree_remove is no longer in cacheline 0
> which improves the performance.
>
>
> [Test Plan]
> I've tested this change, as has Intel. This change has also been upstreamed
> for some time.
>
> [Where problems could occur]
> The risk for regression is fairly low, as we are just changing the layout
> of a stuct to change where members land in the cache.
>
> --
>
> Zhu, Lipeng (1):
> fs/address_space: add alignment padding for i_map and i_mmap_rwsem to
> mitigate a false sharing.
>
> include/linux/fs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
I found that this patch, although originating in v6.6-rc1, already is
applied to Mantic. But it does not use the full cherry pick format (no
upstream SHA1 reference). So I initially missed it.
Applied to jammy:linux/master-next. Thanks.
-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 48643 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240219/056fe046/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240219/056fe046/attachment-0001.sig>
More information about the kernel-team
mailing list