NACK/Cmnt: [V2 j/linux-raspi 1/2] UBUNTU: [Packaging] Remove old snapcraft.yaml

Stefan Bader stefan.bader at canonical.com
Wed Jan 17 08:07:43 UTC 2024


On 16.01.24 22:54, Masahiro Yamada wrote:
> This file was added more than a decade ago, and is no longer working.
> 
> Signed-off-by: Masahiro Yamada <masahiro.yamada at canonical.com>
> ---

Rejected for the following reasons:
- If there is more than one patch a submission should have a cover email 
to group things together.

-Stefan
>   snapcraft.yaml | 36 ------------------------------------
>   1 file changed, 36 deletions(-)
>   delete mode 100644 snapcraft.yaml
> 
> diff --git a/snapcraft.yaml b/snapcraft.yaml
> deleted file mode 100644
> index 2452c4031066..000000000000
> --- a/snapcraft.yaml
> +++ /dev/null
> @@ -1,36 +0,0 @@
> -name: pc-kernel
> -version: null
> -version-script: |
> -    . debian/debian.env
> -    dpkg-parsechangelog -l $DEBIAN/changelog -S version
> -summary: The Ubuntu generic Linux kernel
> -description: This Ubuntu generic Linux kernel
> -grade: stable
> -confinement: strict
> -type: kernel
> -
> -parts:
> -  kernel:
> -    plugin: kernel
> -    source: .
> -    source-type: git
> -    kconfigflavour: generic
> -    kconfigs:
> -      - CONFIG_DEBUG_INFO=n
> -    override-build: |
> -      cp debian/scripts/retpoline-extract-one \
> -        $SNAPCRAFT_PART_BUILD/scripts/ubuntu-retpoline-extract-one
> -      snapcraftctl build
> -    kernel-with-firmware: false
> -  firmware:
> -    plugin: nil
> -    stage-packages:
> -      - linux-firmware
> -    organize:
> -      lib/firmware: firmware
> -    prime:
> -      - -usr
> -      - -lib
> -    build-packages:
> -      - cpio
> -      - libssl-dev

-- 
- Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 48643 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240117/73dbd03e/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240117/73dbd03e/attachment-0001.sig>


More information about the kernel-team mailing list