NACK/Cmt: [PATCH] fbcon: Defer AND delay console takeover

Roxana Nicolescu roxana.nicolescu at canonical.com
Fri Jan 26 09:54:56 UTC 2024


On 25/01/2024 02:20, Daniel van Vugt wrote:
> Please update the wiki, because I did follow the published 
> instructions but clearly there are steps missing:
>
> https://wiki.ubuntu.com/Kernel/Dev/KernelPatches
>
>
> On 24/1/24 18:06, Roxana Nicolescu wrote:
>>
>> On 24-01-2024 07:51, Daniel van Vugt wrote:
>>> Hello Kernel Team,
>>>
>>> Please find attached a patch for a particularly visible bug LP: 
>>> #1970069. And please be gentle, I haven't touched the kernel in over 
>>> a decade.
>>>
>>> - Daniel
>>>
>> Hi,
>>
>> It is not clear which series are of interested here. They should be 
>> included in the subject.
>> This page <https://wiki.ubuntu.com/Kernel/Dev/StablePatchFormat> 
>> should explain the format we expect. TDLR you need to send 2 emails, 
>> one for the cover letter and one for the patch itself.
>> We expect the subject for the cover letter to be 
>> "[SRU][<series>][PATCH 0/1] <Short description of what you want to 
>> solve>"
>> And then the patch should not be send as attachment, but as a 
>> separate email with subject "[SRU][<Series>][PATCH 1/1] fbcon: Defer 
>> AND delay console takeover".
>> Make sure you include the buglink in both. And also make sure the 
>> buglink addresses the series that need to be addressed.
>>
>> Now, looking at the patch, this is not upstream, so it will be a 
>> SAUCE patch. I don't think the impact of this is big enough to 
>> deviate from upstream, therefore
>> I am inclined to not accept it. I would recommend proposing it to 
>> upstream first.
>>
>> Roxana
>
This is the page for stable patches 
https://wiki.ubuntu.com/Kernel/Dev/StablePatchFormat.
I will also add a link in to it in 
https://wiki.ubuntu.com/Kernel/Dev/KernelPatches.



More information about the kernel-team mailing list