NACK/Cmnt: [SRU][J][PATCH 0/2] CVE-2024-27017

[Manuel Diewald]

On Fri, Jun 28, 2024 at 11:07:35AM -0500, Bethany Jamison wrote:
> [Impact]
> 
> netfilter: nft_set_pipapo: walk over current view on netlink dump
> 
> The generation mask can be updated while netlink dump is in progress.
> The pipapo set backend walk iterator cannot rely on it to infer what
> view of the datastructure is to be used. Add notation to specify if user
> wants to read/update the set.
> 
> Based on patch from Florian Westphal.
> 
> [Fix]
> 
> Noble:	pending
> Jammy:	Clean cherry-pick for prereq commit, Backport fix commit for 
> 	context conflict with neighboring function that shouldn't
> 	impact this cve, fix applied as given
> Focal:	not affected
> Bionic: not affected
> Xenial:	not affected
> Trusty: not affected
> 
> [Test Case]
> 
> Compile and boot tested
> 
> [Where problems could occur]
> 
> This fix affects those who use the netfilter framework, an issue with
> this fix would be visible to the user via unexpected system behavior.
> 
> Florian Westphal (1):
>   netfilter: nft_set_pipapo: constify lookup fn args where possible
> 
> Pablo Neira Ayuso (1):
>   netfilter: nft_set_pipapo: walk over current view on netlink dump
> 
>  include/net/netfilter/nf_tables.h   | 13 +++++++
>  net/netfilter/nf_tables_api.c       |  6 +++
>  net/netfilter/nft_set_pipapo.c      | 23 ++++++-----
>  net/netfilter/nft_set_pipapo.h      |  6 +--
>  net/netfilter/nft_set_pipapo_avx2.c | 59 +++++++++++++++++------------
>  5 files changed, 70 insertions(+), 37 deletions(-)
> 
> -- 
> 2.34.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Looks like there is a follow-up fix for

29b359cf6d95 netfilter: nft_set_pipapo: walk over current view on netlink dump

available upstream:

efefd4f00c96 netfilter: nf_tables: missing iterator type in lookup walk

I think we should include it and re-submit.

-- 
 Manuel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240701/fa814b46/attachment-0001.sig>