ACK/Cmnt: [SRU][J:linux-bluefield][PATCH v2 0/1] UBUNTU: SAUCE: mlxbf-gige: Vitesse PHY stuck in a bad state during reboot test

[Tim Gardner]

On 5/14/24 19:59, Asmaa Mnebhi wrote:
> BugLink: https://bugs.launchpad.net/bugs/2064163
> 
> SRU Justification:
> 
> [Impact]
> 
> During the QA reboot test, the BF3 Vitesse PHY gets stuck in a
> bad state, resulting in no ip provisioning. The only way to
> recover is to powercycle.
> We found a software workaround to avoid getting in this state
> in the first place: disable the OOB port in the shutdown
> function.
> 
> [Fix]
> 
> * Prevent the PHY from entering this bad state by disabling
>    the OOB port during shutdown.
> 
> [Test Case]
> 
> * do the reboot test (at least 2000 reboots): run 'reboot' from linux.
> * Check that the oob_net0 interface is up and the ip is assigned.
> * please note that if the the OOB doesn't get an ip, try reloading the driver (rmmod/modprobe).
>    It that solves the issue, that would be a different bug. In the bug at stake, nothing
>    recovers the OOB ip except power cycle.
> 
> [Regression Potential]
> 
> * Make sure the redfish DHCP is still working during the reboot test
> * Make sure the OOB gets an ip
> 
Acked-by: Tim Gardner <tim.gardner at canonical.com>

Its helpful to describe the v1-->v2 delta. I vaguely remember seeing the 
v1 patch, but can't remember why it was rejected (and I'm too lazy to go 
into the list server history and look), though I seem to remember it was 
that the patch caused a build failure. From your description it would 
appear that this patch has been thoroughly tested, right ?

rtg

-----------
Tim Gardner
Canonical, Inc