APPLIED[N]: [SRU Noble/Oracular PATCH 0/1] Fix net:fib_rule_tests.sh in ubuntu_kselftests_net in SRU regression test
Stefan Bader
stefan.bader at canonical.com
Fri May 31 14:31:50 UTC 2024
On 27.05.24 16:42, Masahiro Yamada wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2066332
>
> [Impact]
> This is a change (fix) to kselftests. Of course, the kernel itself is not changed.
>
> In our SRU cycles, all Noble kernels fail in net:fib_rule_tests.sh
> in ubuntu_kselftests_net
>
> 11238 20:50:51 DEBUG| [stdout] # Cannot open network namespace "testns": No such file or directory
>
> This error is caused by the local fix added in 2019:
> "UBUNTU: SAUCE: selftests: net: fix "from" match test in fib_rule_tests.sh"
>
> It was no longer necessary because a similar fix was applied in upstream:
> d1abf388604f ("selftests: fib_rule_tests: enable forwarding before ipv4 from/iif test")
>
> However, such a Ubuntu-local commit is often blindly carried over to future
> releases because nobody re-evaluates whether it is still needed or not.
>
> Now, it is causing a real issue on Noble kselftests.
>
> $ linux/tools/testing/selftests/net$ sudo ./fib_rule_tests.sh
> Cannot open network namespace "testns": No such file or directory
>
> The reason for the failure is obvious; there is no such a namespace since
> the upstream commit 6c0ee7b4d69d ("selftests/net: convert fib_rule_tests.sh to
> run it in unique namespace").
>
> Reverting the outdated commit fixes this failure.
>
> [Fix]
>
> net:fib_rule_tests.sh in ubuntu_kselftests_net will be fixed.
>
> [Test Case]
>
> Just do a regression test, as we do in our normal SRU cycle.
>
> Or, you can directly run, tools/testing/selftests/net/fib_rule_tests.sh
>
>
>
> Masahiro Yamada (1):
> Revert "UBUNTU: SAUCE: selftests: net: fix "from" match test in
> fib_rule_tests.sh"
>
> tools/testing/selftests/net/fib_rule_tests.sh | 2 --
> 1 file changed, 2 deletions(-)
>
Applied to noble:linux/master-next. Thanks.
-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 48643 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240531/71d12a18/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240531/71d12a18/attachment-0001.sig>
More information about the kernel-team
mailing list