NACK: [SRU][j:gcp/gcp-6.8/gke, n:gcp/gke][PATCH 0/1] Move IDPF driver to linux-modules
Manuel Diewald
manuel.diewald at canonical.com
Wed Nov 6 14:23:57 UTC 2024
On Wed, Nov 06, 2024 at 05:50:17AM -0800, Ian Whitfield wrote:
> You're correct, it's missing the prefix, sorry about that. I'll submit a v2.
>
> -Ian
>
> On Wed, 6 Nov 2024 at 04:38, Agathe Porte <agathe.porte at canonical.com> wrote:
> >
> > Hello,
> >
> > 2024-11-01 11:18 CET, Ian Whitfield:
> > > BugLink: https://bugs.launchpad.net/bugs/2086212
> > >
> > > [Impact]
> > >
> > > Google requested the IDPF driver be changed from a built-in module to a
> > > loadable module in the linux-modules package.
> > >
> > > [Fix]
> > >
> > > Add drivers/net/ethernet/intel/idpf/* to the inclusion-list and change
> > > CONFIG_IDPF to build the driver as a loadable module rather than a
> > > built-in. The j:gcp-6.8 patch only changes the inclusion-list because
> > > it will receive the config change during the backport process.
> > >
> > > [Test Plan]
> > >
> > > List files in the linux-modules package and verify that idpf.ko is there.
> > >
> > > [Regression potential]
> > >
> > > The regression potential is very low since we are provably moving a
> > > module to linux-modules.
> > >
> > > Ian Whitfield (1):
> > > Move IDPF driver to linux-modules
> > >
> > > debian.gcp/config/annotations | 4 ++--
> > > debian.gcp/control.d/gcp.inclusion-list | 1 +
> > > 2 files changed, 3 insertions(+), 2 deletions(-)
> >
> > Since this is not a backport, I think it is missing UBUNTU: prefixes
> > before the commit messages?
> >
> > Not directly sending an NAK because I am not sure.
> >
> > Thanks.
> >
> > Agathe.
>
> --
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Cleanup, v2 expected.
--
Manuel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20241106/0a1e5f82/attachment.sig>
More information about the kernel-team
mailing list