ACK/Cmnt: [PATCH noble] UBUNTU: [Packaging] add linux-bpf-dev package

[Luca Boccassi]

On Tue, 12 Nov 2024 at 13:35, Agathe Porte <agathe.porte at canonical.com> wrote:
>
> 2024-10-18 20:58 CEST, luca.boccassi at gmail.com:
> > From: Luca Boccassi <bluca at debian.org>
> >
> > BugLink: https://bugs.launchpad.net/bugs/2050083
> >
> > Add a new binary linux-bpf-dev package that ships a generated vmlinux.h
> > header. This can be used by packages building CO-RE BPF programs instead
> > of generating it at build time based on the kernel running on the package
> > build system, which might or might not match the kernel that is actually
> > shipped. It ensures that a matching header can always be used.
> >
> > Matches changes in Debian, including the package name and header installation
> > location, so that we do not have to ifdef:
> >
> > https://salsa.debian.org/kernel-team/linux/-/commit/f52d006f3915ac4358dc8c98aa417477ebee026e
> >
> > This is already used by systemd to build various CO-RE programs, and
> > right now on Ubuntu due to the lack of this package the header is
> > generated from sysfs in the build system where the systemd packages are
> > built.
> >
> > Signed-off-by: Luca Boccassi <bluca at debian.org>
> > ---
> > This has been in Oracular for a while, if possible it would be great to have the
> > new package also in Noble, so that we can use it in the systemd upstream build
> > and CI.
>
> Acked-by: Agathe Porte <agathe.porte at canonical.com>
>
> If think the patch should have the following trailing lines given it is
> a cherry-pick from oracular:
>
>     Signed-off-by: Luca Boccassi <bluca at debian.org>
>     Signed-off-by: Timo Aaltonen <timo.aaltonen at canonical.com>
>     (cherry-picked from commit 6032cf45d201ec539a8efa493989366bde75fd96 oracular:linux)
>     Signed-off-by: Luca Boccassi <bluca at debian.org>
>
> Just my two cents.
>
> Thanks.

Sure, makes sense. Do I need to re-send, or can that be added when
applying? Thanks!