ACK: [SRU][J:linux-bluefield][PATCH v1 0/6] bluefield_edac: replace SAUCE patches with upstream content

Agathe Porte agathe.porte at canonical.com
Thu Nov 14 06:08:47 UTC 2024


2024-10-24 20:59 CEST, David Thompson:
> BugLink: https://bugs.launchpad.net/bugs/2085561
> 
> SRU Justification:
> 
> [Impact]
> The BlueField-1/BlueField-2 EDAC driver in Jammy repo consists of several SAUCE patches.
> There are now equivalent upstream patches that should be used instead.
> 
> [Fix]
> 1) Revert the three SAUCE patches for bluefield_edac driver
> 2) Cherry pick four upstream patches for bluefield_edac driver
> 
> [Test Case]
> 
> 1) Boot BlueField-2 with relevant software
> 
> 2) Check initial state of correctable error count, should be 0
>   $ cat /sys/devices/system/edac/mc/mc0/ce_count
> 
> 3) Find sysfs entry for DRAM ECC injection
>   $ find / -name 'DRAM_ECC_INJECT'
> 
> 4) Inject ECC error
>   $ echo 1 > OUTPUT-FROM-STEP3-ABOVE
> 
> 5) Repeat step 4 until this error message appears on console
>     "ERROR: BL31: MSS0 EMEM MI Single bit ECC detected"
> 
> 6) Check new state of correctable error count, should be non-zero
>   $ cat /sys/devices/system/edac/mc/mc0/ce_count
> 
> [Regression Potential]
> Low potential, as upstream commits have been tested and vetted by upstream maintainers.
> 
> David Thompson (5):
>   Revert "UBUNTU: SAUCE: bluefield-edac: Fix potential integer overflow"
>   Revert "UBUNTU: SAUCE: bluefield_edac: Update license and copyright info"
>   Revert "UBUNTU: SAUCE: bluefield_edac: Add SMC support"
>   EDAC/bluefield: Fix potential integer overflow
>   EDAC/bluefield: Use Arm SMC for EMI access on BlueField-2
> 
> Uwe Kleine-König (1):
>   EDAC/bluefield: Convert to platform remove callback returning void
> 
>  drivers/edac/bluefield_edac.c | 144 ++++++++++++++++------------------
>  1 file changed, 66 insertions(+), 78 deletions(-)

Acked-by: Agathe Porte <agathe.porte at canonical.com>



More information about the kernel-team mailing list