[SRU][Oracular][PATCH v2 0/1] hid-asus: use hid for brightness control on keyboard
Mitchell Augustin
mitchell.augustin at canonical.com
Wed Nov 20 17:20:31 UTC 2024
BugLink: https://bugs.launchpad.net/bugs/2089113
SRU Justification:
[ Impact ]
The brightness of some ASUS ROG laptop keyboards cannot be adjusted
without this patch.
[ Test Plan ]
I verified that this patch applies cleanly to the Oracular kernel
at Ubuntu-6.11.0-9.9 and resolves the bug on my laptop
(Asus ROG GA503RM). I observed no regressions. This can be verified
on any similar model of laptop by testing keyboard brightness controls
once patched.
[ Fix ]
On almost all ASUS ROG series laptops the MCU used for the USB keyboard
also has a HID packet used for setting the brightness. This is usually
the same as the WMI method. But in some laptops the WMI method either
is missing or doesn't work, so we should default to the HID control.
[ Where problems could occur ]
I do not expect any regressions since this only touches parts of
asus-wmi and hid-asus that are covered by my test case, which worked
as intended.
[ Changes since v1 of this patch set ]
Corrected patch format issues
Luke D. Jones (1):
hid-asus: use hid for brightness control on keyboard
drivers/hid/hid-asus.c | 7 +++++
drivers/platform/x86/asus-wmi.c | 3 +-
include/linux/platform_data/x86/asus-wmi.h | 36 ++++++++++++++++++++++
3 files changed, 45 insertions(+), 1 deletion(-)
--
2.43.0
More information about the kernel-team
mailing list