NACK: [SRU][N/O/P][PATCH 0/3]Enable speaker/mic mute LEDs on Lenovo ideapad and thinkbook

Mehmet Basaran mehmet.basaran at canonical.com
Tue Apr 8 11:34:15 UTC 2025


There is a v2 on ML.

Nacked-by: Mehmet Basaran <mehmet.basaran at canonical.com>

-------------- next part --------------
Aaron Ma <aaron.ma at canonical.com> writes:

> BugLink: https://bugs.launchpad.net/bugs/2106449
>
> [Impact]
> On Lenovo ideapad/thinkbook products, the speaker/mic mute LEDs
> failed to work.
>
> [Fix]
> Add Lenovo wmi hotkey driver, and bind the LEDs to audio codec.
> commits:
> d466887a94787 ALSA: hda: Support for Ideapad hotkey mute LEDs
> 61250669eaa9f platform/x86:lenovo-wmi-hotkey-utilities.c: Support for mic and audio mute LEDs
>
> [Test]
> Vendor tested on hardware, the speaker/mic mute work fine with LEDs.
>
> [Where problems could occur]
> It make break audio support on Lenovo laptops.
>
> This is critical for certified Lenovo thinkbook products,
> fixes impacting functionality, is required to maintain certification.
>
> Aaron Ma (1):
>   UBUNTU: [Config] Enable Lenovo wmi hotkey driver
>
> Jackie Dong (2):
>   ALSA: hda: Support for Ideapad hotkey mute LEDs
>   platform/x86:lenovo-wmi-hotkey-utilities.c: Support for mic and audio
>     mute LEDs
>
>  MAINTAINERS                                   |   6 +
>  debian.master/config/annotations              |   1 +
>  drivers/platform/x86/Kconfig                  |  11 +
>  drivers/platform/x86/Makefile                 |   1 +
>  .../x86/lenovo-wmi-hotkey-utilities.c         | 211 ++++++++++++++++++
>  sound/pci/hda/ideapad_hotkey_led_helper.c     |  36 +++
>  sound/pci/hda/patch_conexant.c                |  13 +-
>  sound/pci/hda/patch_realtek.c                 |  19 +-
>  8 files changed, 296 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/platform/x86/lenovo-wmi-hotkey-utilities.c
>  create mode 100644 sound/pci/hda/ideapad_hotkey_led_helper.c
>
> -- 
> 2.43.0
>
>
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 873 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250408/1eac9ff6/attachment.sig>


More information about the kernel-team mailing list