ACK Re: [SRU][P][PATCH 0/1] gve: unlink old napi only if page pool exists
Timo Aaltonen
tjaalton at ubuntu.com
Tue Apr 8 13:59:10 UTC 2025
Tim Whisonant kirjoitti 8.4.2025 klo 3.13:
> BugLink: https://bugs.launchpad.net/bugs/2106281
>
> SRU Justification:
>
> [Impact]
>
> gve: unlink old napi only if page pool exists
>
> Commit de70981f295e ("gve: unlink old napi when stopping a queue using
> queue API") unlinks the old napi when stopping a queue. But this breaks
> QPL mode of the driver which does not use page pool. Fix this by checking
> that there's a page pool associated with the ring.
>
> [Fix]
>
> Plucky: clean cherry pick from upstream
> Oracular: not affected
> Noble: not affected
> Jammy: not affected
> Focal: not affected
> Bionic: not affected
> Xenial: not affected
> Trusty: not affected
>
> [Test Plan]
>
> Compile and boot tested.
>
> [Where problems could occur]
>
> The change occurs in the gVNIC ethernet driver. Problems would affect
> the ring buffer processing logic for these devices.
>
> Harshitha Ramamurthy (1):
> gve: unlink old napi only if page pool exists
>
> drivers/net/ethernet/google/gve/gve_rx_dqo.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Acked-by: Timo Aaltonen <timo.aaltonen at canonical.com>
--
t
More information about the kernel-team
mailing list