NACK: [SRU][N][PATCH v2 0/2] Included missing upstream commits for LP: #2102181

[Koichiro Den]

On Tue, Apr 15, 2025 at 01:36:41AM GMT, Mehmet Basaran wrote:
> BugLink: https://bugs.launchpad.net/bugs/2107336

Now the BugLink and commit id in the provenance section for each commit
looks good.

> 
> [ Impact ]
> When applying upstream stable patchset (v6.6.67, v6.12.6) we forgot to include:
> 
> acea3779b2aa libperf cpumap: Add any, empty and min helpers
> 
> As a result kernel fails to compile.

Maybe this shoule be 'tools(/perf) fails to compile'?

> 
> [ Fix ]
> Included missing upstream commits for LP: #2102181 (Upstream stable to v6.6.67, v6.12.6)
> commits:
> b6b4a62d8525 libperf cpumap: Add any, empty and min helpers
> dcd45b376d0a libperf cpumap: Ensure empty cpumap is NULL from alloc

These commits landed into mainline during its merge window for v6.10, and
not relevant to upstream stable branches.
The provenance section for each commit should not include "... linux-6.12.y)"
That's why I NACK this.

Besides, why did you pick the second commit for this submission? Although
the original patch series submitted on upstream includes both, I'm not sure
whether we really need to include it in this SRU patch submission.

> 
> [Test]
> Compile and build tested.
> 
> [Where problems could occur]
> Patches are pretty safe (only additions) and unlikely to introduce bugs.
> 
> 
> Ian Rogers (2):
>   libperf cpumap: Add any, empty and min helpers
>   libperf cpumap: Ensure empty cpumap is NULL from alloc
> 
>  tools/lib/perf/cpumap.c              | 33 +++++++++++++++++++++++++++-
>  tools/lib/perf/include/perf/cpumap.h | 16 ++++++++++++++
>  tools/lib/perf/libperf.map           |  4 ++++
>  3 files changed, 52 insertions(+), 1 deletion(-)
> 
> -- 
> 2.43.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team