ACK/Cmnt: [SRU][N:linux-azure-nvidia][PATCH 0/1] Include cppc_cpufreq in linux-modules

[Vinicius Peixoto]

Hi Ioanna,

On Mon Aug 4, 2025 at 2:45 PM -03, ioanna-maria.alifieraki wrote:
> From: Ioanna Alifieraki <ioanna-maria.alifieraki at canonical.com>
>
> BugLink: https://bugs.launchpad.net/bugs/2119465
>
> [Impact]
> Include cppc_cpufreq module in linux-modules package instead of
> linux-modules-extra so that cpufreq is enabled by default (without
> the need to install linux-modules-extra).
>
> The fix is fairly simple, add the cppc_cpufreq.ko modules to 
> azure-nvidia.inclusion-list.

This is a super minor nitpick, but in the [Impact] section we usually
give a short description of how this is impacting users, and then add a
[Fix] section that describes the actual fix. Something like this:

 [Impact]

 Users of the azure-nvidia kernel have been running into issues with
 configuring CPU governors due to the cppc_cpufreq.ko not being included
 in the linux-modules package:

  root at gb2002159h3828:~# cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
  cat: /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor: No such file or directory
  root at gb2002159h3828:~# uname -a
  Linux gb2002159h3828 6.8.0-1016-azure-nvidia #17-Ubuntu SMP Sat May 3 01:11:52 UTC 2025 aarch64 aarch64 aarch64 GNU/Linux

 [Fix]

 Include cppc_cpufreq module in linux-modules package instead of
 linux-modules-extra so that cpufreq is enabled by default (without
 the need to install linux-modules-extra).

 The fix is fairly simple, add the cppc_cpufreq.ko modules to 
 azure-nvidia.inclusion-list. 

No need to submit a v2 for this, IMO; I'd be happy with just adding that
change to the LP bug description.

With that small nit addressed:

Acked-by: Vinicius Peixoto <vinicius.peixoto at canonical.com>

> [Test Case]
>
> Currently cppc_cpufreq is not included in linux-modules package.
>
> root at flavio:/home/ubuntu# uname -rv
> 6.8.0-1019-azure-nvidia #20-Ubuntu SMP Fri Jun 27 23:52:00 UTC 2025
> root at flavio:/home/ubuntu# lsmod | grep cpufreq
> root at flavio:/home/ubuntu#
> root at flavio:/home/ubuntu# cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
> cat: /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor: No such file or directory
>
> Preparing a test kernel with the fix and installing only the linux-image
> and linux-modules package, cppc_cpufreq is present.
>
> ubuntu at flavio:~$ uname -rv
> 6.8.0-1020-azure-nvidia #21 SMP Mon Aug 4 16:37:34 UTC 2025
>
> root at flavio:/home/ubuntu# lsmod | grep cpufreq
> cppc_cpufreq 262144 0
> root at flavio:/home/ubuntu# cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
> ondemand
>
> [Where problems could occur]
>
> The fix just adds a module in linux-modules package. Not any severe
> regressions expected. However, those who expected to find this module
> in modules-extra will not find there anymore.
>
> [Other]
>
> The fix is needed for linux-azure-nvidia, for Noble, 6.8.
> SF#413581
>
>
> Ioanna Alifieraki (1):
>   UBUNTU: [Config] azure-nvidia: add cppc_cpufreq to
>     azure-nvidia.inclusion-list
>
>  debian.azure-nvidia/control.d/azure-nvidia.inclusion-list | 1 +
>  1 file changed, 1 insertion(+)