NACK/Cmt: [SRU][J][PATCH v2 0/1] CVE-2023-52593

[Alice Munduruca]

Sounds good, I will re-submit with a corrected v3

On Wed, 6 Aug 2025 at 16:57, Thibault Ferrante
<thibault.ferrante at canonical.com> wrote:
>
> On 06/08/2025 19:01, alice.munduruca at canonical.com wrote:
> > From: "Alice C. Munduruca" <alice.munduruca at canonical.com>
> >
> > [ Impact ]
> >
> > No check is made in `wfx_set_mfp_ap` in case the function
> > `ieee80211_beacon_get` returns a null pointer in case of error.
> > As a result, we add a check to ensure a null pointer dereference
> > does not occur.
> >
> > [ Fix ]
> >
> > Jammy: Backported from torvalds/linux --
> >         `wfx_hif_set_mfp` was changed to the applicable
> >         `hif_set_mfp` given the lack of namespacing prior
> >         to commit fcd6c0f9a12369ae6d500d747e668ed98ef5edd6.
> There is an upstream fix commit targeting this one that I would expect to be included:
> 6d30bb88f623 wifi: wfx: repair open network AP mode>
> > [ Test Plan ]
> >
> > Compile and boot tested, since no hardware is available.
> >
> > [ Where problems could occur ]
> >
> > It's possible that the additional checks (although marked with the
> > unlikely macro) could result in performance degradations should the
> > function be called sufficiently often.
>
> It's generally nice to include the diff between different version submission
> to make reviewing easier. Such as:
> v2 -> add backport note to the commit message>
> > Dmitry Antipov (1):
> >    wifi: wfx: fix possible NULL pointer dereference in wfx_set_mfp_ap()
> >
> >   drivers/staging/wfx/sta.c | 43 +++++++++++++++++++++++----------------
> >   1 file changed, 25 insertions(+), 18 deletions(-)
> >
>