ACK: [SRU][kernel-snaps-u24.04][PATCH 1/1] nvidia-templates: set nvidia-stream if unset for EOL components

[Wen-chien Jesse Sung]

Aaron Jauregui <aaron.jauregui at canonical.com> writes:

> BugLink: https://bugs.launchpad.net/bugs/2119706
>
> We rely on the pc-kernel configure hook to detect and upgrade EOL
> drivers. To avoid an existing issue where installing components on first
> boot causing images to become unbootable, the configure hook only runs
> if the nvidia-stream parameter has been set (snap set snap set pc-kernel
> nvidia-stream=550-erd, etc).
>
> Upgrading from the 550 (now EOL) driver to the 570 driver does not
> happen, as this value is not set by default. This leaves the user with
> an empty 550 driver that fails. This commit adds a post-refres hook for
> the EOL ko component to set the nvidia-stream parameter if it is not
> already set (and thus trigger the component hook). Note that since this
> is a post-refresh hook it should not trigger when installing a new EOL
> module, but it will handle the upgrade case.
>
> Signed-off-by: Aaron Jauregui <aaron.jauregui at canonical.com>
> ---
>  nvidia-templates/eol-part-tmpl | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/nvidia-templates/eol-part-tmpl b/nvidia-templates/eol-part-tmpl
> index 0a1f2f1..aa9c8a8 100644
> --- a/nvidia-templates/eol-part-tmpl
> +++ b/nvidia-templates/eol-part-tmpl
> @@ -5,7 +5,11 @@
>  
>        echo "@REPLACEMENT_VER at -erd" > "$CRAFT_PART_INSTALL/eol"
>  
> +      # set post-refresh hook to ensure eol driver upgrades if not yet set
> +      printf "#!/bin/bash\nsnapctl set nvidia-stream=@MAJOR_VER at -erd\n" > $CRAFT_PART_INSTALL/refresh
> +
>      organize:
> +      refresh: (component/nvidia- at MAJOR_VER@-erd-ko)/snap/hooks/post-refresh
>        eol: (component/nvidia- at MAJOR_VER@-erd-ko)/eol
>  
>    nvidia- at MAJOR_VER@-erd-user-comp:
> -- 
> 2.43.0
>
>
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Wen-chien Jesse Sung <jesse.sung at canonical.com>