NACK: [SRU][N:linux-bluefield][PATCH v1 0/3] pinctrl-mlxbf3: should enable 'const pinctrl_desc' in Noble

[David Thompson]

> Hi,
> There is two issues in the submission:
> There is a fix commit upstream available 457d9772e8a5 pinctrl: airoha: fix wrong
> PHY LED mapping and PHY2 LED defines
> 

Hi Thibault,

We never intend to enable the Airoha pinctrl driver in the BlueField Kconfig.
The only reason it was added to this patch series to enable clean apply of patch #3,
which affects our BlueField-3 pinctrl driver.

Is it acceptable to keep this series as-is, or would you recommend a different approach?

As a side topic, I did not directly receive your email Thibault.  I had to notice your NACK
on the Ubuntu webpage.  Is that expected?

- Dave


> The annotations should be updated to reflect the changes, here is the failure log
> when building:
> 
> python3 debian/scripts/misc/annotations -f
> /build/noble/debian.bluefield/config/annotations \
> 	--arch arm64 --flavour bluefield --check /build/noble/debian/build/build-
> bluefield/.config
> check-config: loading annotations from
> /build/noble/debian.bluefield/config/annotations
> check-config: CONFIG_PINCTRL_AIROHA changed from - to n: undefined)
> check-config: 1 config options have been changed, review them with `git diff`
> 
> On 04/08/2025 16:36, David Thompson wrote:
> > BugLink: https://bugs.launchpad.net/bugs/2119333
> >
> > SRU Justification:
> >
> > [Impact]
> > Recent upstream changes to kernel and the BlueField-3 pin control
> > driver, pinctrl-mlxbf3, support the use of "const pinctrl_desc". This
> > critical driver structure should make use of this technique for improved stability.
> >
> > [Fix]
> > The fix is to cherry pick the following upstream patch:
> >      490bfd1ca556 pinctrl: Constify static 'pinctrl_desc'
> > It may be required to cherry pick other upstream patches so that
> > everything applies cleanly.
> >
> > [Test Case]
> > * Boot BlueField-3 platform with software containing fix
> > * Verify that pinctrl-mlxbf3 modules is loaded properly
> > * Check the kernel log via dmesg for proper messages from pinctrl
> > subsystem
> > * Verify that there are no kernel faults caused by pinctrl-mlxbf3
> > * Reboot several times and keep checking log
> >
> > [Regression Potential]
> > This fix is upstreamed and tested well.
> >
> > Krzysztof Kozlowski (2):
> >    pinctrl: Constify pointers to 'pinctrl_desc'
> >    pinctrl: Constify static 'pinctrl_desc'
> >
> > Lorenzo Bianconi (1):
> >    pinctrl: airoha: Add support for EN7581 SoC
> >
> >   MAINTAINERS                                   |    7 +
> >   drivers/pinctrl/berlin/berlin.c               |    2 +-
> >   drivers/pinctrl/cirrus/pinctrl-cs42l43.c      |    2 +-
> >   drivers/pinctrl/core.c                        |   13 +-
> >   drivers/pinctrl/core.h                        |    2 +-
> >   drivers/pinctrl/mediatek/Kconfig              |   17 +-
> >   drivers/pinctrl/mediatek/Makefile             |    1 +
> >   drivers/pinctrl/mediatek/pinctrl-airoha.c     | 2970 +++++++++++++++++
> >   drivers/pinctrl/pinctrl-artpec6.c             |    2 +-
> >   drivers/pinctrl/pinctrl-bm1880.c              |    2 +-
> >   drivers/pinctrl/pinctrl-k210.c                |    2 +-
> >   drivers/pinctrl/pinctrl-lpc18xx.c             |    2 +-
> >   drivers/pinctrl/pinctrl-mlxbf3.c              |    2 +-
> >   drivers/pinctrl/pinctrl-tb10x.c               |    2 +-
> >   drivers/pinctrl/pinctrl-zynq.c                |    2 +-
> >   .../starfive/pinctrl-starfive-jh7100.c        |    2 +-
> >   include/linux/pinctrl/pinctrl.h               |    8 +-
> >   17 files changed, 3016 insertions(+), 22 deletions(-)
> >   create mode 100644 drivers/pinctrl/mediatek/pinctrl-airoha.c
> >