[SRU][N][PATCH 1/1] UBUNTU: SAUCE: netfilter: ctnetlink: Fix -Wuninitialized in ctnetlink_secctx_size()

[Magali Lemes]

BugLink: https://bugs.launchpad.net/bugs/2120561

When compiling with Clang, the following warning shows up:

net/netfilter/nf_conntrack_netlink.c:674:41: warning: variable 'len' is uninitialized when used here [-Wuninitialized]
  674 |                + nla_total_size(sizeof(char) * len); /* CTA_SECCTX_NAME */
      |                                                ^~~
net/netfilter/nf_conntrack_netlink.c:667:9: note: initialize the variable 'len' to silence this warning
  667 |         int len, ret;
      |                ^
      |                 = 0

Fix the warning by removing the uninitialized `len` variable and matching
upstream commit 2d470c778120 ("lsm: replace context+len with lsm_context").

Fixes: c45f92d3c95e ("UBUNTU: SAUCE: apparmor4.0.0 [17/90]: LSM stacking v39: LSM: Use lsmcontext in security_secid_to_secctx")
Signed-off-by: Magali Lemes <magali.lemes at canonical.com>
---
 net/netfilter/nf_conntrack_netlink.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c
index f8575cdc0f5f..0eac66981acf 100644
--- a/net/netfilter/nf_conntrack_netlink.c
+++ b/net/netfilter/nf_conntrack_netlink.c
@@ -664,14 +664,14 @@ static inline size_t ctnetlink_acct_size(const struct nf_conn *ct)
 static inline int ctnetlink_secctx_size(const struct nf_conn *ct)
 {
 #ifdef CONFIG_NF_CONNTRACK_SECMARK
-	int len, ret;
+	int ret;
 
 	ret = security_secid_to_secctx(ct->secmark, NULL);
 	if (ret < 0)
 		return 0;
 
 	return nla_total_size(0) /* CTA_SECCTX */
-	       + nla_total_size(sizeof(char) * len); /* CTA_SECCTX_NAME */
+	       + nla_total_size(sizeof(char) * ret); /* CTA_SECCTX_NAME */
 #else
 	return 0;
 #endif
-- 
2.48.1