NACK/Cmnt: [SRU P][PATCH 0/4] CVE-2025-38239 megaraid_sas: Features and Bug Fixes

[Stefan Bader]

On 14.08.25 02:52, Michael Reed wrote:
> From: Michael Reed <Michael.Reed at canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/2107492
> 
> SRU Justification:
> 
> garaid_sas: Fix for a potential deadlock
> 5f60d5f6bbc1 move asm/unaligned.h to linux/unaligned.h
> 571d81b482f0 scsi: megaraid_sas: Remove trailing space after \n newline
> b97c0741c7dc scsi: Expand all create*_workqueue() invocations
> 29b4a4975077 scsi: megaraid_sas: struct MR_HOST_DEVICE_LIST: Replace 1-element array with flexible array
> ed8ab02c85b3 scsi: megaraid_sas: struct MR_LD_VF_MAP: Replace 1-element arrays with flexible arrays
> aa57abe6a7f9 megaraid_sas: don't set QUEUE_FLAG_NOMERGES
> 529ed2d8b670 scsi: megaraid_sas: Use PCI_IRQ_INTX instead of PCI_IRQ_LEGACY
> b57089d32c2c scsi: megaraid_sas: Switch to using ->device_configure
> e75f7555e1e7 scsi: megaraid: Indent Kconfig option help text
> 
> CVE-2025-38239
> 752eb816b55 scsi: megaraid_sas: Fix invalid node index
> 
> [Test Plan]
> - Driver load/unlaod
> - virtual drive creation (R0, R1) and deletion
> - JBOD creation and deletion
> - IO run with different profiles (4k...1M) on VDs and JBODs,
> - Controller reset while running IOs
> - Event handling
> 
> [Where problems could occur]
> 
> Regression Risk is low. The changes are confined to the megaraid_sas driver
> 
> [Other Info]
> 
> https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/plucky/+ref/lp_2107492_megaraid_sas_update_3
> 
> See original description
> 
> Bart Van Assche (1):
>    scsi: usb: Rename the RESERVE and RELEASE constants
> 
> Chandrakanth Patil (1):
>    scsi: megaraid_sas: Driver version update to 07.734.00.00-rc1
> 
> Chen Yu (1):
>    scsi: megaraid_sas: Fix invalid node index
> 
> Dr. David Alan Gilbert (1):
>    scsi: megaraid_sas: Make most module parameters static
> 
>   drivers/message/fusion/mptscsih.c            |  4 ++--
>   drivers/scsi/aacraid/aachba.c                |  4 ++--
>   drivers/scsi/arm/acornscsi.c                 |  2 +-
>   drivers/scsi/ips.c                           |  8 ++++----
>   drivers/scsi/megaraid.c                      | 10 +++++-----
>   drivers/scsi/megaraid/megaraid_mbox.c        | 10 +++++-----
>   drivers/scsi/megaraid/megaraid_sas.h         |  4 ++--
>   drivers/scsi/megaraid/megaraid_sas_base.c    | 16 ++++++++++------
>   drivers/target/target_core_device.c          |  8 ++++----
>   drivers/target/target_core_pr.c              |  6 +++---
>   drivers/target/target_core_spc.c             | 20 ++++++++++----------
>   drivers/usb/gadget/function/f_mass_storage.c |  4 ++--
>   drivers/usb/storage/debug.c                  |  4 ++--
>   include/scsi/scsi_proto.h                    |  4 ++--
>   include/trace/events/scsi.h                  |  4 ++--
>   include/trace/events/target.h                |  4 ++--
>   16 files changed, 58 insertions(+), 54 deletions(-)
> 



Rejected for the following reasons:
- Will be split into CVE and bug fix changes
- Try to improve the justification info to be more clear about the 
background and regression potential

-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 48643 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250822/7ec6ed93/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250822/7ec6ed93/attachment-0001.sig>