NACK/Cmnt: [SRU P][PULL][PATCH 00/11] mpi3mr: Features and Bug Fixes

[Stefan Bader]

On 15.08.25 01:52, Michael Reed wrote:
> From: Michael Reed <Michael.Reed at canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/2107490
> 
> SRU Justification:
> 
> [Impact]
> 
> We can see that the mpi3mr driver inbox version in the 24.04.02 point kernel is 8.9.10.51 which is pretty old. We would request to include the following mpi3mr patch set in the upcoming 24.04.03 point release (tentative release is on June-July).
> 
> [Fix]
> A full list of mpi3mr driver Upstream commits are listed in the description of the bug
> https://bugs.launchpad.net/bugs/2107490
> 
> [Test Plan]
> 
> Covered following test cases:
> 
> - Inbox driver load and unload multiple times through modprobe
> - Virtual drives creation (R0, R1) and Deletion
> - Jbod Creation and deletion
> - Events validation
> - IO run on VD and JBOD with different IO profiles (Like, IO with 4k..1M, different io depth etc..)
> 
> [Where problems could occur]
> 
> [Other Info]
> 
> https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/plucky/+ref/lp_2107490_mpi3mr
> 
> The following changes since commit 8ce4b18871779592c4f49210612f19cdb5721022:
> 
>    scsi: Constify struct pci_error_handlers (2025-07-08 16:24:02 -0500)
> 
> are available in the Git repository at:
> 
>    https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/plucky/+ref/lp_2107490_mpi3mr
> 
> for you to fetch changes up to 6c786d955bedaf450865cf429798fb7566a6361e:
> 
>    scsi: mpi3mr: Reset the pending interrupt flag (2025-07-08 16:29:20 -0500)
> 
> ----------------------------------------------------------------
> Chandrakanth Patil (1):
>        scsi: mpi3mr: Task Abort EH Support
> 
> Colin Ian King (1):
>        scsi: mpi3mr: Fix spelling mistake "skiping" -> "skipping"
> 
> Kees Cook (1):
>        scsi: mpi3mr: Mark device strings as nonstring
> 
> Ranjan Kumar (7):
>        scsi: mpi3mr: Support for Segmented Hardware Trace buffer
>        scsi: mpi3mr: Update driver version to 8.12.1.0.50
>        scsi: mpi3mr: Update MPI Headers to revision 35
>        scsi: mpi3mr: Update timestamp only for supervisor IOCs
>        scsi: mpi3mr: Check admin reply queue from Watchdog
>        scsi: mpi3mr: Update driver version to 8.13.0.5.50
>        scsi: mpi3mr: Reset the pending interrupt flag
> 
>   drivers/scsi/mpi3mr/mpi/mpi30_cnfg.h      |   4 ++
>   drivers/scsi/mpi3mr/mpi/mpi30_image.h     |   8 +++
>   drivers/scsi/mpi3mr/mpi/mpi30_init.h      |  11 +++-
>   drivers/scsi/mpi3mr/mpi/mpi30_ioc.h       |  21 ++++++
>   drivers/scsi/mpi3mr/mpi/mpi30_tool.h      |   1 +
>   drivers/scsi/mpi3mr/mpi/mpi30_transport.h |  20 +++++-
>   drivers/scsi/mpi3mr/mpi3mr.h              |  20 +++++-
>   drivers/scsi/mpi3mr/mpi3mr_app.c          | 104 +++++++++++++++++++++++++++---
>   drivers/scsi/mpi3mr/mpi3mr_fw.c           |  63 ++++++++++++++++--
>   drivers/scsi/mpi3mr/mpi3mr_os.c           |  99 ++++++++++++++++++++++++++++
>   drivers/scsi/mpi3mr/mpi3mr_transport.c    |   8 +--
>   11 files changed, 336 insertions(+), 23 deletions(-)
> 



Rejected for the following reasons:
Right now the SRU description in the bug report does not really reflect 
the changes submitted. The justification is for the Noble backport and 
IMO that is not doable. There is no way one can be sure there are no odd 
things happening between the older block subsystem and the newest driver 
version. And for that reason we have HWE kernels which require less 
effort. Now this submission is for Plucky and then HWE-6.14 but there is 
no explanation which helps people looking at this to understand why the 
bug lists a large set and the submission is much shorter. And why its 
done there and won't be done in the LTS GA kernel. So what I am asking 
for is not changing the patches but submit again when the bug report and 
that goes into the submission email as well, has been clarified.
[I hope that will also make people NOT look the other way and run]

-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 48643 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250826/c92050d1/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250826/c92050d1/attachment-0001.sig>