ACK: [SRU][N][PATCH 0/4] Fix ubuntu_bpf/setup build error

[Philip Cox]

On 2025-12-08 12:41 a.m., Masahiro Yamada wrote:
> BugLink: https://bugs.launchpad.net/bugs/2112357
>
>
> [Impact]
>
>    Currently, ubuntu_bpf/setup fails to build (hinted) in our
>    regression testing.
>    This patch set cherry-pici/backport some missing dependen
>    in order to fix the build errors.
>
>    The compilation error looks as follows:
>
>      EXT-OBJ  [test_progs] test_progs.o
>    test_progs.c: In function ‘netns_new’:
>    test_progs.c:692:23: error: ‘struct prog_test_def’ has no member named ‘should_tmon’; did you mean ‘should_run’?
>      692 |         if (env.test->should_tmon ||
>          |                       ^~~~~~~~~~~
>          |                       should_run
>    test_progs.c:693:52: error: ‘struct subtest_state’ has no member named ‘should_tmon’
>      693 |             (env.subtest_state && env.subtest_state->should_tmon)) {
>          |                                                    ^~
>    test_progs.c:696:35: error: implicit declaration of function ‘traffic_monitor_start’ [-Werror=implicit-function-declaration]
>      696 |                 netns_obj->tmon = traffic_monitor_start(nsname, test_name, subtest_name);
>          |                                   ^~~~~~~~~~~~~~~~~~~~~
>    test_progs.c:696:33: error: assignment to ‘struct tmonitor_ctx *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
>      696 |                 netns_obj->tmon = traffic_monitor_start(nsname, test_name, subtest_name);
>          |                                 ^
>    test_progs.c:713:9: error: implicit declaration of function ‘traffic_monitor_stop’ [-Werror=implicit-function-declaration]
>      713 |         traffic_monitor_stop(netns_obj->tmon);
>          |         ^~~~~~~~~~~~~~~~~~~~
>    cc1: all warnings being treated as errors
>
> [Test  Case]
>
>    Compile test the BPF kselftest.
>
> Eduard Zingerman (1):
>    selftests/bpf: extract utility function for BPF disassembly
>
> Hou Tao (1):
>    selftests/bpf: Factor out get_xlated_program() helper
>
> Kui-Feng Lee (2):
>    selftests/bpf: Add traffic monitor functions.
>    selftests/bpf: Add the traffic monitor option to test_progs.


     Acked-by: Philip Cox <philip.cox at canonical.com>


>   tools/testing/selftests/bpf/Makefile          |   5 +
>   tools/testing/selftests/bpf/disasm_helpers.c  |  51 ++
>   tools/testing/selftests/bpf/disasm_helpers.h  |  12 +
>   tools/testing/selftests/bpf/network_helpers.c | 454 ++++++++++++++++++
>   tools/testing/selftests/bpf/network_helpers.h |  18 +
>   .../selftests/bpf/prog_tests/ctx_rewrite.c    | 118 +----
>   tools/testing/selftests/bpf/test_progs.c      |  92 ++--
>   tools/testing/selftests/bpf/test_progs.h      |   2 +
>   tools/testing/selftests/bpf/test_verifier.c   |  47 +-
>   tools/testing/selftests/bpf/testing_helpers.c |  43 ++
>   tools/testing/selftests/bpf/testing_helpers.h |   6 +
>   11 files changed, 668 insertions(+), 180 deletions(-)
>   create mode 100644 tools/testing/selftests/bpf/disasm_helpers.c
>   create mode 100644 tools/testing/selftests/bpf/disasm_helpers.h
>