ACK/Cmnt: [SRU][F][PATCH 0/1] CVE-2024-26915

[Koichiro Den]

On Sun, Feb 09, 2025 at 11:38:28AM GMT, Ian Whitfield wrote:
> [Impact]
> 
> This patchset is intended to address CVE-2024-26915, which is an issue
> with overflow detection in input handler rings in the amdgpu drivers.
> The issue leads to overflows being missed after the first overflow is
> handled, because the "overflow cleared" bit is not reset.
> 
> [Backport]
> 
> The patch includes changes for several input handling blocks for drivers
> not supported in this version of the kernel, so these files were
> ignored. The patch doesn't depend on any of these files to be effective.
> The patch was also edited in one driver to reverse a change which used
> caching functionality from patches not present in this kernel, which was
> a relatively simple alteration.
> 
> [Fix]
> 
> Oracular:	not affected
> Noble:		not affected
> Jammy:		fixed via stable updates
> Focal:		backport
> Bionic:		sent to ESM ML
> Xenial:		sent to ESM ML
> 
> [Test Case]
> 
> Compile and boot tested.
> 
> [Where problems could occur]
> 
> This fix affects AMD GPU users. An issue with this fix would be visible
> to the user as random system lockups or unchecked ring buffer overflows
> in the amdgpu input handler, leading to unexpected behavior of the
> device.
> 
> Friedrich Vock (1):
>   drm/amdgpu: Reset IH OVERFLOW_CLEAR bit
> 
>  drivers/gpu/drm/amd/amdgpu/cik_ih.c     | 6 ++++++
>  drivers/gpu/drm/amd/amdgpu/cz_ih.c      | 5 +++++
>  drivers/gpu/drm/amd/amdgpu/iceland_ih.c | 5 +++++
>  drivers/gpu/drm/amd/amdgpu/navi10_ih.c  | 6 ++++++
>  drivers/gpu/drm/amd/amdgpu/si_ih.c      | 6 ++++++
>  drivers/gpu/drm/amd/amdgpu/tonga_ih.c   | 6 ++++++
>  drivers/gpu/drm/amd/amdgpu/vega10_ih.c  | 6 ++++++
>  7 files changed, 40 insertions(+)
> 

Acked-by: Koichiro Den <koichiro.den at canonical.com>

if backported 9a9d00c23d17 from linux-5.15.y instead, the note in the
trailer can be a bit more compact (2/4 misssing commits can be dropped):

  [ijwhitfield: ignored changes in files not present in this kernel
  version introduced by the commits:
- 6e02c0ed4bb5 ("drm/amdgpu: add ih v6_0 ip block v2")
- 0ba96fd3c017 ("drm/amdgpu: add ih 6.1 support")
  bebd4c79a4eb ("drm/amdgpu: create vega20 ih blocks")
  Edited the patch to reverse a change from missing commit
  2d2fbf685c89 ("drm/amdgpu: use cached ih rb control reg offsets for navi10")]