NACK: [PATCH 0/1][SRU][Oracular] Add version information for Intel ISH firmware

[Stewart Hore]

On Tue, Feb 18, 2025 at 12:16:26PM +0800, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/2095390
>
> [Impact]
>
> No version information from Intel ISH firmware blobs available for userspace
> test cases.
>
> [Fix]
>
> v6.13-rc1 commit ac0cba6837729 ("HID: intel-ish-hid: Add firmware version sysfs
> attributes") introduced two (optional) sysfs attributes, base_version and
> project_version under firmware node for further reference.
>
> [Test Case]
>
> 1. With proposed kernel installed
> 2. With additional Intel ISH firmware blobs that supports version info in the
>    header manifest, e.g. blobs proposed for bug 2094768.
> 3. check if sysfs attributes for the ish firmware become available:
>    ```
>    $ cat /sys/devices/pci0000\:00/0000\:00\:12.0/firmware/base_version
>    5.8.0.7716
>
>    $ cat /sys/devices/pci0000\:00/0000\:00\:12.0/firmware/project_version
>    5.8.0.12472
>    ```
>
> [Where problems could occur]
>
> This extracts optional version info from the binary blob. No other side effect.
>
> [Other Info]
>
> While this depends on custom firmware loading from bug 2094768, nominate for
> series with kernel v6.11 and on.
>
> Zhang Lixu (1):
>   HID: intel-ish-hid: Add firmware version sysfs attributes
>
>  drivers/hid/intel-ish-hid/ipc/pci-ish.c     | 45 +++++++++++++++++++++
>  drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 12 ++++++
>  drivers/hid/intel-ish-hid/ishtp/loader.c    | 35 +++++++++++++++-
>  drivers/hid/intel-ish-hid/ishtp/loader.h    | 34 ++++++++++++++++
>  4 files changed, 125 insertions(+), 1 deletion(-)
>
> --
> 2.47.1

Please resubmit with correct subject line format, must start with [SRU]

[SRU][O][PATCH 0/1] ...

See: https://wiki.ubuntu.com/Kernel/Dev/StablePatchFormat

> --
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team