NACK/Cmnt: [SRU][kernel-snaps-uc24.04/pc][PATCH 1/1] snapcraft.yaml: bump kernel version and cleanup

[Stefan Bader]

On 18.02.25 07:26, Aaron Jauregui wrote:
> Signed-off-by: Aaron Jauregui <aaron.jauregui at canonical.com>
> ---
>   snapcraft.yaml | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/snapcraft.yaml b/snapcraft.yaml
> index 9acefeb..9ff27b3 100644
> --- a/snapcraft.yaml
> +++ b/snapcraft.yaml
> @@ -41,13 +41,11 @@ parts:
>         - kmod
>   
>       stage-packages:
> -      - linux-image-uc-generic=6.8.0-52.53
> +      - linux-image-uc-generic=6.8.0-56.58

Rejected for the following reasons:
This would not apply since I adjusted (actually messed up with that) the 
version when applying. I think you should fetch before re-submitting. 
But also, just to clarify, this would be a one time change to get things 
going before SWM catches up. Ultimately this should be a placeholder 
(like @KVERSION@) which SWM modifies when creating the per risk/stream 
updates.

-Stefan
>   
>       override-build: |
>         craftctl default
>   
> -      echo BULID
> -
>         # Determine version and 'uname -r'
>         unamer=$(basename "$CRAFT_PART_INSTALL"/lib/modules/*)
>         version="$(apt show linux-image-uc-"$unamer" 2>/dev/null | sed -n 's/^Version: //p' | head -n1)"
> @@ -76,7 +74,6 @@ parts:
>         post-refresh.pc-kernel: snap/hooks/post-refresh
>   
>       override-stage: |
> -      echo STAGE
>   
>         # Determine 'uname -r'
>         unamer=$(basename "$CRAFT_PART_INSTALL"/lib/modules/*)
> @@ -130,7 +127,7 @@ parts:
>   
>       override-build: |
>         craftctl default
> -      version="$(craftctl get version)"
> +      version=$(craftctl get version)
>   
>         # Duplicate libc causing conflicts, deleting to use system's libc
>         rm -f -- "$CRAFT_PART_INSTALL/usr/lib/$(uname -m)-linux-gnu/libc.so.6"


-- 
- Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 47863 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250218/7360ab96/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250218/7360ab96/attachment-0001.sig>