NACK: [PATCH 0/2][SRU][OEM-6.8] Respect _WOV entry in BIOS when enabling microphone on AMD acp6x platforms

[Stewart Hore]

On Tue, Feb 18, 2025 at 02:31:56PM +0800, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/2093162
>
> [Impact]
>
> AMD acp6x driver may not respect BIOS settings and enables DMIC (digital
> microphone) unexpectedly.
>
> [Fix]
>
> * Upstream v6.13-rc1 commit 4095cf872084 ("ASoC: amd: yc: Fix for enabling DMIC
>   on acp6x via _DSD entry")
> * And two following fixes also from v6.13-rcX: commit 984795e76def ("ASoC: amd:
>   yc: Fix the wrong return value") and commit 88438444fddd ("ASoC: amd: ps: Fix
>   for enabling DMIC on acp63 platform via _DSD entry"). The latter is only
>   needed for kernel >= v6.9.
>
> [Test Case]
>
> 1) Check BIOS if microphone is turned on/off.
> 2) Ensure that microphone is present or not in OS (acp6x device binds or not) to
>    match this policy.
> 3) Change policy in BIOS.
> 4) Ensure that OS behavior matches.
>
> [Where problems could occur]
>
> This basically checks whether the value in _WOV valid and enabled. Existing
> systems might found their microphone disabled then, but that's to respect the
> settings in BIOS.
>
> [Other Info]
>
> This affects kernel >= v5.19, and some of the changes have been backported to
> v6.12.x and v6.11.x.
>
> Venkata Prasad Potturu (2):
>   ASoC: amd: yc: Fix for enabling DMIC on acp6x via _DSD entry
>   ASoC: amd: yc: Fix the wrong return value
>
>  sound/soc/amd/yc/acp6x-mach.c | 23 ++++++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
>
> --
> 2.47.1

Subject line needs to follow the stable patch format.

https://canonical-kernel-docs.readthedocs-hosted.com/en/latest/reference/stable-patch-format/#stable-patch-format



> --
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team