[P/U] [PATCH v2 1/7] UBUNTU: [packaging] remove $(wildcard $(DEBIAN)/control.d/*) dependency

Masahiro Yamada masahiro.yamada at canonical.com
Thu Feb 20 06:33:35 UTC 2025


Using wildcard does not add flexibility in this context. Even if a
derivative kernel adds an additional stub file in the ${DEBIAN/control.d/
directory, it has no effect because debian/scripts/control-create
hardcodes the stub files:

  stub="${DEBIAN}/control.d/flavour-control.stub debian/control.d/flavour-buildinfo.stub"

These two files are always used, regardless of any other stub files
present in ${DEBIAN/control.d/.

Comparing timestamps between the target and prerequisites is unnecessary
because this rule is always executed due to:

  .PHONY: $(DEBIAN)/control.stub

It cannot detect the accidental removal of flavour-control.stub or
flavour-buildinfo.stub, as $(wildcard $(DEBIAN)/control.d/*) would
become empty in such a case.

In summary, this prerequisite serves no useful purpose.

Signed-off-by: Masahiro Yamada <masahiro.yamada at canonical.com>
---

 debian/rules | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/debian/rules b/debian/rules
index ade26dd751eb..b70559afa0c4 100755
--- a/debian/rules
+++ b/debian/rules
@@ -182,8 +182,7 @@ $(DEBIAN)/control.stub: 				\
 		$(control_files)			\
 		debian/canonical-revoked-certs.pem	\
 		debian/control.d/flavour-module.stub	\
-		$(DEBIAN)/changelog			\
-		$(wildcard $(DEBIAN)/control.d/*)
+		$(DEBIAN)/changelog
 	for i in $(control_files); do                                           \
 	  cat $$i;                                                              \
 	  echo "";                                                              \
-- 
2.43.0




More information about the kernel-team mailing list