NACK: [SRU][O/P][PATCH 00/27] Add Intel Touch Host Controller drivers

[Koichiro Den]

On Fri, Jan 24, 2025 at 06:40:56PM GMT, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/2096624
> 
> [Impact]
> The new touchscreen on Intel LNL is lack of driver support.
> 
> 00:10.0 Digitizer Pen [0901]: Intel Corporation Device [8086:a848] (rev 10)
> 
> [Fix]
> Enable Intel THC driver to support it.
> [ 4.122639] input: quicki2c-hid 27C6:012D Touchscreen as /devices/pci0000:00/0000:00:10.0/0001:27C6:012D.0003/input/input12
> [ 4.122704] input: quicki2c-hid 27C6:012D as /devices/pci0000:00/0000:00:10.0/0001:27C6:012D.0003/input/input13
> 
> [Test]
> Tested on hardware, multi-touch works fine on Wacom and Goodix touchscreens.
> 
> [Where problems could occur]
> It introduces a brand new driver, may break hid functions.
> 
> Because this is a new feature driver, SRU for oracular/plucky/oem-6.11.
> 
> Aaron Ma (1):
>   UBUNTU: [Config] Enable Intel THC HID Support
> 
> Dan Carpenter (1):
>   HID: intel-thc-hid: intel-thc: Fix error code in thc_i2c_subip_init()
> 
> Even Xu (16):
>   HID: THC: Add documentation
>   HID: intel-thc-hid: intel-thc: Add THC DMA interfaces
>   HID: intel-thc-hid: intel-thc: Add THC I2C config interfaces
>   HID: intel-thc-hid: intel-quickspi: Add THC QuickSPI driver hid layer
>   HID: intel-thc-hid: intel-quickspi: Add THC QuickSPI ACPI interfaces
>   HID: intel-thc-hid: intel-quickspi: Add HIDSPI protocol implementation
>   HID: intel-thc-hid: intel-quickspi: Add PM implementation
>   HID: intel-thc-hid: intel-quicki2c: Add THC QuickI2C driver skeleton
>   HID: intel-thc-hid: intel-quicki2c: Add THC QuickI2C driver hid layer
>   HID: intel-thc-hid: intel-quicki2c: Add THC QuickI2C ACPI interfaces
>   HID: intel-thc-hid: intel-quicki2c: Add HIDI2C protocol implementation
>   HID: intel-thc-hid: intel-quicki2c: Complete THC QuickI2C driver
>   HID: intel-thc-hid: intel-quicki2c: Add PM implementation
>   HID: Wacom: Add PCI Wacom device support
>   HID: intel-thc-hid: intel-quicki2c: fix potential memory corruption
>   HID: intel-thc-hid: fix build errors in um mode
> 
> Xinpeng Sun (9):
>   HID: intel-thc-hid: Add basic THC driver skeleton
>   HID: intel-thc-hid: intel-thc: Add THC registers definition
>   HID: intel-thc-hid: intel-thc: Add THC PIO operation APIs
>   HID: intel-thc-hid: intel-thc: Add APIs for interrupt
>   HID: intel-thc-hid: intel-thc: Add THC LTR interfaces
>   HID: intel-thc-hid: intel-thc: Add THC interrupt handler
>   HID: intel-thc-hid: intel-thc: Add THC SPI config interfaces
>   HID: intel-thc-hid: intel-quickspi: Add THC QuickSPI driver skeleton
>   HID: intel-thc-hid: intel-quickspi: Complete THC QuickSPI driver
> 
>  Documentation/hid/index.rst                   |    1 +
>  Documentation/hid/intel-thc-hid.rst           |  568 ++++++
>  MAINTAINERS                                   |    6 +
>  debian.master/config/annotations              |    3 +
>  drivers/hid/Kconfig                           |    2 +
>  drivers/hid/Makefile                          |    2 +
>  drivers/hid/intel-thc-hid/Kconfig             |   43 +
>  drivers/hid/intel-thc-hid/Makefile            |   22 +
>  .../intel-quicki2c/pci-quicki2c.c             |  969 ++++++++++
>  .../intel-quicki2c/quicki2c-dev.h             |  186 ++
>  .../intel-quicki2c/quicki2c-hid.c             |  166 ++
>  .../intel-quicki2c/quicki2c-hid.h             |   14 +
>  .../intel-quicki2c/quicki2c-protocol.c        |  224 +++
>  .../intel-quicki2c/quicki2c-protocol.h        |   20 +
>  .../intel-quickspi/pci-quickspi.c             |  987 +++++++++++
>  .../intel-quickspi/quickspi-dev.h             |  172 ++
>  .../intel-quickspi/quickspi-hid.c             |  165 ++
>  .../intel-quickspi/quickspi-hid.h             |   14 +
>  .../intel-quickspi/quickspi-protocol.c        |  414 +++++
>  .../intel-quickspi/quickspi-protocol.h        |   25 +
>  .../intel-thc-hid/intel-thc/intel-thc-dev.c   | 1578 +++++++++++++++++
>  .../intel-thc-hid/intel-thc/intel-thc-dev.h   |  116 ++
>  .../intel-thc-hid/intel-thc/intel-thc-dma.c   |  969 ++++++++++
>  .../intel-thc-hid/intel-thc/intel-thc-dma.h   |  146 ++
>  .../intel-thc-hid/intel-thc/intel-thc-hw.h    |  881 +++++++++
>  drivers/hid/wacom_wac.c                       |    5 +
>  include/linux/hid-over-i2c.h                  |  117 ++
>  include/linux/hid-over-spi.h                  |  155 ++
>  28 files changed, 7970 insertions(+)
>  create mode 100644 Documentation/hid/intel-thc-hid.rst
>  create mode 100644 drivers/hid/intel-thc-hid/Kconfig
>  create mode 100644 drivers/hid/intel-thc-hid/Makefile
>  create mode 100644 drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
>  create mode 100644 drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-dev.h
>  create mode 100644 drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c
>  create mode 100644 drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.h
>  create mode 100644 drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-protocol.c
>  create mode 100644 drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-protocol.h
>  create mode 100644 drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
>  create mode 100644 drivers/hid/intel-thc-hid/intel-quickspi/quickspi-dev.h
>  create mode 100644 drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c
>  create mode 100644 drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.h
>  create mode 100644 drivers/hid/intel-thc-hid/intel-quickspi/quickspi-protocol.c
>  create mode 100644 drivers/hid/intel-thc-hid/intel-quickspi/quickspi-protocol.h
>  create mode 100644 drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c
>  create mode 100644 drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.h
>  create mode 100644 drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
>  create mode 100644 drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.h
>  create mode 100644 drivers/hid/intel-thc-hid/intel-thc/intel-thc-hw.h
>  create mode 100644 include/linux/hid-over-i2c.h
>  create mode 100644 include/linux/hid-over-spi.h
> 

After discussion, we decided not to apply this at the moment.

Reasons:
- Plucky will likely incorporate these changes without extra effort.
- There is no urgent need to backport this to Oracular right now.
- We'll work on getting HWE kernels out as soon as possible.

In any case, thank you for the submission.
Just for ML clean-up, NACK-ing for now.