ACK/Cmnt: [SRU][N:linux-azure-nvidia][PULL] Hyper-V and MANA enhancements

[Philip Cox]

On 2025-02-14 5:21 p.m., John Cabaj wrote:
> BugLink: https://bugs.launchpad.net/bugs/2098508
>
> SRU Justification
>
> [Impact]
>
> * Microsoft requested patches to implement debugfs in MANA driver to 
> improve debugging in userspace, improve available settings in ethtool, 
> and vmbus enhancements to fix potential hang and improve throughput
>
> [Fix]
>
> * 6 clean cherry-picks from upstream
> * 1 simple backports from upstream
>
> [Test Plan]
>
> * Compile tested
> * Boot tested
> * Will be further tested by Microsoft
>
> [Regression potential]
>
> * Changes are largely localized to MANA and hyper-v. scsi change 
> simply initializes as variable that should have already been 
> initialized. Most changes have been upstreamed for some months.
> * Introduction of debugfs to MANA driver could introduce regressions 
> if not well tested.
>
> [Other info]
>
> * SF#00406456
>
> ----------------------------------------------------------------
>
> The following changes since commit 
> f9fafc970d711be2be14c394a00404c59e3896cf:
>
>   UBUNTU: Ubuntu-azure-nvidia-6.8.0-1010.11 (2025-02-10 11:48:31 -0600)
>
> are available in the Git repository at:
>
>
> https://git.launchpad.net/~john-cabaj/ubuntu/+source/linux-azure/+git/azure-nvidia 
> hyper-v-mana
>
> for you to fetch changes up to f5d30bfad4583214c1929abe78c1e49c3ac08da1:
>
>   scsi: storvsc: Set correct data length for sending SCSI command 
> without payload (2025-02-14 10:48:52 -0600)
>


A have a few comments about the commit messages that I will type under 
each commit in the list.  Just fix before you push and I'm happy.




> ----------------------------------------------------------------
> Erni Sri Satya Vennela (2):
>       net: netvsc: Update default VMBus channels
>       net: mana: Add get_link and get_link_ksettings in ethtool

After the final upstram "signed-off", and before the "cherry-picked 
from" line there is an extra newline.  drop it.

> Haiyang Zhang (1):
>       hv_netvsc: Fix VF namespace also in synthetic NIC 
> NETDEV_REGISTER event

After the final upstram "signed-off", and before the "cherry-picked 
from" line there is an extra newline.  drop it.

> Long Li (1):
>       scsi: storvsc: Set correct data length for sending SCSI command 
> without payload
>
> Shradha Gupta (3):
>       net: mana: Increase the DEF_RX_BUFFERS_PER_QUEUE to 1024

After the final upstram "signed-off", and before the "cherry-picked 
from" line there is an extra newline.  drop it.

> net: mana: Enable debugfs files for MANA device

In general, it is nice if you list where the context changes are, or 
give a hint at least.  Not really needed now, as the review is done.


> net: mana: Cleanup "mana" debugfs dir after cleanup of all children
>
>  drivers/net/ethernet/microsoft/mana/gdma_main.c    |  43 
> ++++++++++++++++++++++++++++++++++++++++++-
>  drivers/net/ethernet/microsoft/mana/mana_en.c      | 103 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  drivers/net/ethernet/microsoft/mana/mana_ethtool.c |  11 +++++++++++
>  drivers/net/hyperv/hyperv_net.h                    |   2 +-
>  drivers/net/hyperv/netvsc_drv.c                    |  33 
> ++++++++++++++++++++++++++++++++-
>  drivers/scsi/storvsc_drv.c                         |   1 +
>  include/net/mana/gdma.h                            |   6 +++++-
>  include/net/mana/mana.h                            |  10 +++++++++-
>  8 files changed, 203 insertions(+), 6 deletions(-)


Touch up the commit messages, and this series is

Acked-by: Philip Cox <philip.cox at canonical.com>