ACK/Cmnt: [SRU][N:linux-azure-nvidia][PATCH 0/4] iommu NULL pointer dereference in tegra241_vintf_alloc_lvcmdq

Vinicius Peixoto vinicius.peixoto at canonical.com
Tue Feb 25 21:37:37 UTC 2025


On Tue Feb 25, 2025 at 6:20 PM -03, John Cabaj wrote:
> BugLink: https://bugs.launchpad.net/bugs/2097573

Minor nit, but I wonder if this should point to
https://bugs.launchpad.net/bugs/2100199?

Regardless:

Acked-by: Vinicius Peixoto <vinicius.peixoto at canonical.com>

>
> SRU Justification
>
> [Impact]
>
> * Patches pulled from upstream for CMDQV support introduce null pointer dereference on Grace hardware
>
> [Fix]
>
> * 4 clean cherry-picks from upstream
> * All but one commits are tagged as Fixes: 918eb5c856f6 ("iommu/arm-smmu-v3: Add in-kernel support for NVIDIA Tegra241 (Grace) CMDQV"), which was introduced in https://bugs.launchpad.net/bugs/2097573
> * Additional commit to ensure clean cherry-picks of other patches
>
> [Test Plan]
>
> * Compile tested
> * Boot tested
> * Tested on Grace Hopper hardware
>
> [Regression potential]
>
> * Regression risk low as patches are self-contained to drivers/iommu/arm/arm-smmu-v3 and are upstream and tested
>
> Dan Carpenter (1):
>   iommu/tegra241-cmdqv: Fix ioremap() error handling in probe()
>
> Luis Claudio R. Goncalves (1):
>   iommu/tegra241-cmdqv: do not use smp_processor_id in preemptible
>     context
>
> Nicolin Chen (2):
>   iommu/tegra241-cmdqv: Drop static at local variable
>   iommu/tegra241-cmdqv: Do not allocate vcmdq until
>     dma_set_mask_and_coherent
>
>  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c   |  9 +-
>  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h   |  1 +
>  .../iommu/arm/arm-smmu-v3/tegra241-cmdqv.c    | 93 +++++++++++--------
>  3 files changed, 65 insertions(+), 38 deletions(-)




More information about the kernel-team mailing list