NACK/Cmnt: [SRU][F][PATCH 0/1] CVE-2024-26915

[Koichiro Den]

On Sun, Feb 09, 2025 at 11:38:28AM GMT, Ian Whitfield wrote:
> [Impact]
> 
> This patchset is intended to address CVE-2024-26915, which is an issue
> with overflow detection in input handler rings in the amdgpu drivers.
> The issue leads to overflows being missed after the first overflow is
> handled, because the "overflow cleared" bit is not reset.
> 
> [Backport]
> 
> The patch includes changes for several input handling blocks for drivers
> not supported in this version of the kernel, so these files were
> ignored. The patch doesn't depend on any of these files to be effective.
> The patch was also edited in one driver to reverse a change which used
> caching functionality from patches not present in this kernel, which was
> a relatively simple alteration.
> 
> [Fix]
> 
> Oracular:	not affected
> Noble:		not affected
> Jammy:		fixed via stable updates
> Focal:		backport
> Bionic:		sent to ESM ML
> Xenial:		sent to ESM ML
> 
> [Test Case]
> 
> Compile and boot tested.
> 
> [Where problems could occur]
> 
> This fix affects AMD GPU users. An issue with this fix would be visible
> to the user as random system lockups or unchecked ring buffer overflows
> in the amdgpu input handler, leading to unexpected behavior of the
> device.
> 
> Friedrich Vock (1):
>   drm/amdgpu: Reset IH OVERFLOW_CLEAR bit
> 
>  drivers/gpu/drm/amd/amdgpu/cik_ih.c     | 6 ++++++
>  drivers/gpu/drm/amd/amdgpu/cz_ih.c      | 5 +++++
>  drivers/gpu/drm/amd/amdgpu/iceland_ih.c | 5 +++++
>  drivers/gpu/drm/amd/amdgpu/navi10_ih.c  | 6 ++++++
>  drivers/gpu/drm/amd/amdgpu/si_ih.c      | 6 ++++++
>  drivers/gpu/drm/amd/amdgpu/tonga_ih.c   | 6 ++++++
>  drivers/gpu/drm/amd/amdgpu/vega10_ih.c  | 6 ++++++
>  7 files changed, 40 insertions(+)
> 

This failed to build. Focal does not include any commit from the patch
series below:
https://lore.kernel.org/amd-gfx/20201212154600.21618-1-Hawking.Zhang@amd.com/
Please resolve the issue, test it and re-submit.
Thanks.

---(build log)---
In file included from /build/focal/drivers/gpu/drm/amd/amdgpu/vega10_ih.c:26:
/build/focal/drivers/gpu/drm/amd/amdgpu/vega10_ih.c: In function 'vega10_ih_get_wptr':
/build/focal/drivers/gpu/drm/amd/amdgpu/vega10_ih.c:427:16: error: 'ih_regs' undeclared (first use in this function); did you mean 'pt_regs'?
  427 |  WREG32_NO_KIQ(ih_regs->ih_rb_cntl, tmp);
      |                ^~~~~~~
/build/focal/drivers/gpu/drm/amd/amdgpu/amdgpu.h:1059:53: note: in definition of macro 'WREG32_NO_KIQ'
 1059 | #define WREG32_NO_KIQ(reg, v) amdgpu_mm_wreg(adev, (reg), (v), AMDGPU_REGS_NO_KIQ)
      |                                                     ^~~
/build/focal/drivers/gpu/drm/amd/amdgpu/vega10_ih.c:427:16: note: each undeclared identifier is reported only once for each function it appears in
  427 |  WREG32_NO_KIQ(ih_regs->ih_rb_cntl, tmp);
      |                ^~~~~~~
/build/focal/drivers/gpu/drm/amd/amdgpu/amdgpu.h:1059:53: note: in definition of macro 'WREG32_NO_KIQ'
 1059 | #define WREG32_NO_KIQ(reg, v) amdgpu_mm_wreg(adev, (reg), (v), AMDGPU_REGS_NO_KIQ)
      |                                                     ^~~
  CC [M]  drivers/gpu/drm/nouveau/nvkm/subdev/clk/nv04.o
  CC [M]  drivers/gpu/drm/radeon/rv770_dpm.o
make[6]: *** [/build/focal/scripts/Makefile.build:270: drivers/gpu/drm/amd/amdgpu/vega10_ih.o] Error 1
make[5]: *** [/build/focal/scripts/Makefile.build:519: drivers/gpu/drm/amd/amdgpu] Error 2
make[5]: *** Waiting for unfinished jobs....