NACK: [PATCH] UBUNTU: [Packaging] perf: enable debuginfod support

[Juerg Haefliger]

On Thu,  7 Nov 2024 10:26:59 +0100
Hector CAO <hector.cao at canonical.com> wrote:

> From: Hector Cao <hector.cao at canonical.com>
> 
> For symbols resolution, the perf tool can use debuginfod server as source
> of debuginfo files. This support can be requested through the argument
> `--debuginfod` of `perf record` command. For example, to use Ubuntu debuginfod
> server:
> 
> perf record --debuginfod='https://debuginfod.ubuntu.com' -p <pid>
> 
> This support requires the perf tool to be built with libdebuginfod
> library. However, this library is not a build dependency of the kernel
> currently.
> This patch adds libdebuginfod-dev as build dependency of the kernel
> so that the debuginfod support is enabled for `perf`.
> 
> Signed-off-by: Hector Cao <hector.cao at canonical.com>
> ---
>  debian.master/control.stub.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/debian.master/control.stub.in b/debian.master/control.stub.in
> index 744dce7bb70e..5eea311e6649 100644
> --- a/debian.master/control.stub.in
> +++ b/debian.master/control.stub.in
> @@ -34,6 +34,7 @@ Build-Depends:
>   libstdc++-dev,
>   libtool <!stage1>,
>   libtraceevent-dev [amd64 arm64 armhf ppc64el s390x riscv64] <!stage1>,
> + libdebuginfod-dev [amd64 arm64 armhf ppc64el s390x riscv64] <!stage1>,

Please keep the alphabetical sort order.


>   libtracefs-dev [amd64 arm64 armhf ppc64el s390x riscv64] <!stage1>,
>   libudev-dev <!stage1>,
>   libunwind8-dev [amd64 arm64 armhf ppc64el] <!stage1>,


Also, the subject line needs to specify the target kernel/series. Since this
is unstable (and plucky), it should be:

[Unstable/P][Patch] UBUNTU: [Packaging] perf: enable debuginfod support

...Juerg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250116/7294d7e7/attachment.sig>