NACK: [kernel-snaps-uc22][PATCH 0/1] add build-time check for nvidia firmware
Juerg Haefliger
juerg.haefliger at canonical.com
Fri Jan 17 12:27:44 UTC 2025
ML cleanup.
...Juerg
> BugLink: https://bugs.launchpad.net/bugs/2089509
>
> [Impact]
> This adds a test preventing pc-kernel builds from succeeding
> if nvidia firmware isn't present in the snap at the end of
> the build stage. The reason for this behavior is currently
> unknown and this patch does not fix the root cause of the
> problem, but it prevents pushing out incorrect snaps and should
> help us debug the problem if and when it fails.
>
> [Fix]
> The snap build fails if "$CRAFT_PART_INSTALL"/lib/firmware/nvidia
> is not present at the end of the build stage. Note that the final
> snap organizes /lib/firmware into /firmware after this stage.
>
> [Regression Potential]
> Regression potential is low, as this should only affect
> build-time behavior.
>
> Aaron Jauregui (1):
> snapcraft.yaml: add check for nvidia firmware files
>
> snapcraft.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250117/6f475e8f/attachment.sig>
More information about the kernel-team
mailing list