NACK: [SRU][N:linux-bluefield][PATCH v1 0/1] UBUNTU: SAUCE: Add ipmb_host driver

[Kuba Pawlak]

On 30.06.2025 23:49, Asmaa Mnebhi wrote:
> BugLink: https://bugs.launchpad.net/bugs/2115687
>
> SRU Justification:
>
> [Fix]
>
> * Support the ipmb_host.c driver on the Noble branch.
>
> [Test Case]
>
> * check that ipmb_host.c driver is loaded at boot time with no errors (lsmod/modinfo)
> * check that the /dev/ipmi0 device file is created successfully
> * Please note that this driver (like other host IPMI drivers), depends on ippmi_msghandler.c and ipmi_devint.c. They have to be loaded for ipmb_host.c to be loaded successfully
> * send ipmi commands from the BF DPU to the BMC and make sure the response is as expected.
>
> [Regression Potential]
>
> Any of the test cases above could be impacted due to these changes.
>

The patch does not build:
/build/noble/drivers/char/ipmi/ipmb_host.c:261:11: error: conflicting 
types for 'ipmb_checksum'; have 'u8(u8 *, int,  u8)' {aka 'unsigned 
char(unsigned char *, int,  unsigned char)'}
   261 | static u8 ipmb_checksum(u8 *data, int size, u8 start)
       |           ^~~~~~~~~~~~~
In file included from /build/noble/include/linux/ipmi_smi.h:21,
                  from /build/noble/drivers/char/ipmi/ipmb_host.c:13:
/build/noble/include/linux/ipmi.h:344:15: note: previous declaration of 
'ipmb_checksum' with type 'unsigned char(unsigned char *, int)'
   344 | unsigned char ipmb_checksum(unsigned char *data, int size);
       |               ^~~~~~~~~~~~~
/build/noble/drivers/char/ipmi/ipmb_host.c:817:18: error: initialization 
of 'int (*)(struct i2c_client *)' from incompatible pointer type 'int 
(*)(struct i2c_client *, const struct i2c_device_id *)' 
[-Werror=incompatible-pointer-types]
   817 |         .probe = ipmb_probe,
       |                  ^~~~~~~~~~
/build/noble/drivers/char/ipmi/ipmb_host.c:817:18: note: (near 
initialization for 'ipmb_driver.probe')
/build/noble/drivers/char/ipmi/ipmb_host.c:818:19: error: initialization 
of 'void (*)(struct i2c_client *)' from incompatible pointer type 'int 
(*)(struct i2c_client *)' [-Werror=incompatible-pointer-types]
   818 |         .remove = ipmb_remove,
       |                   ^~~~~~~~~~~
/build/noble/drivers/char/ipmi/ipmb_host.c:818:19: note: (near 
initialization for 'ipmb_driver.remove')
cc1: some warnings being treated as errors


Please resend v2 with all dependencies


Nacked-by: Kuba Pawlak <kuba.pawlak at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0x216A9D7E3B63DCB4.asc
Type: application/pgp-keys
Size: 3139 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250709/3f84f2c0/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250709/3f84f2c0/attachment-0001.sig>