NACK: [SRU][P/N:linux-azure][PATCH v2 0/8] azure: backport various SMB multichannel fixes

[Philip Cox]

A few comments...

- I like that you provided the links to the patches, not just the sha1.  
It does make it a little easier.  Some people may not feel that way, but 
I liked it.

- It is annoying that the git commits you listed in the cover, are in a 
different order than the patch set.


The reason I am NACK'ing is mainly the cover letter and LP bug info.  
I've reviewed the patchsets, and they are fine, just the cover letter 
and LP bug need some work.

- The [Impact] section is severely lacking.  Neither the cover letter 
nor the launchpad bug give any info and are useless to anyone who 
doesn't have access to salesforce.   Even just a sentence or two 
summarizing the overall goal of the issue would be better.  The 
salesforce ticket has a good summary in the Impact section, you could 
use it.

- The info in the cover letter and LP bug info is kinda in the wrong 
place.  The Impact section should be in the Fix section.


Something like this would be better:


[Impact]

There are SMB mount stability issues with SMB multichannel mounts. 
Especially when the share migrates to a new server.

[Fix]

Microsoft has asked us to pull the following patchset into the Plucky
and Noble linux-azure trees:

cifs: do not disable interface polling on failure (upstream 6.6, 6.12, 
6.15, and 6.16)
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=42ca547b13a20e7cbb04fbdf8d5f089ac4bb35b7
.....

smb: client: fix warning when reconnecting channel (upstream 6.6, 6.12, 
6.15, and 6.16)
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3bbe46716092d8ef6b0df4b95 
6f585c5cd0fc78e

All patches were cleanly cherry-picked into the Noble and Plucky 
linux-azure tree.
[Test plan]

Build tested only; Microsoft will validate the bug fix.

[Where problems could occur]

The changes here could cause errors when managing SMB filesystems with 
channels connected to multiple different servers.

[Other info]
SF #00413632







On 2025-07-28 3:12 p.m., Vinicius Peixoto wrote:
> BugLink: https://bugs.launchpad.net/bugs/2118807
>
> [Impact]
>
> Microsoft has asked us to pull the following patchset into the Plucky
> and Noble linux-azure trees:
>
> cifs: do not disable interface polling on failure (upstream 6.6, 6.12, 6.15, and 6.16)
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=42ca547b13a20e7cbb04fbdf8d5f089ac4bb35b7
>
> cifs: serialize other channels when query server interfaces is pending (upstream 6.6, 6.12, 6.15, and 6.16)
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b5e3e6e28cf3853566ba5d816f79aba5be579158
>
> cifs: deal with the channel loading lag while picking channels (upstream 6.6, 6.12, 6.15, and 6.16)
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=66d590b828b1fd9fa337047ae58fe1c4c6f43609
>
> cifs: dns resolution is needed only for primary channel (upstream 6.6, 6.12, 6.15, and 6.16)
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b4f60a053a2534c3e510ba0c1f8727566adf8317
>
> cifs: update dstaddr whenever channel iface is updated (upstream 6.6, 6.12, 6.15, and 6.16)
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c1846893991f3b4ec8a0cc12219ada153f0814d6
>
> cifs: reset connections for all channels when reconnect requested (upstream 6.1, 6.6, 6.12, 6.15, and 6.16)
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1f396b9bfe39aaf55ea74a7005806164b236653d
>
> smb: client: fix potential deadlock when reconnecting channels (upstream 6.6, 6.12, 6.15, and 6.16)
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=711741f94ac3cf9f4e3aa73aa171e76d188c0819
>
> smb: client: fix warning when reconnecting channel (upstream 6.6, 6.12, 6.15, and 6.16)
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3bbe46716092d8ef6b0df4b95 6f585c5cd0fc78e
>
> [Fix]
>
> All patches were cleanly cherry-picked into the Noble and Plucky linux-azure tree.
>
> [Test plan]
>
> Build tested only; Microsoft will validate the bug fix.
>
> [Where problems could occur]
>
> The changes here could cause errors when managing SMB filesystems with channels connected to multiple different servers.
>
> [Other info]
> SF #00413632
>
> Paulo Alcantara (2):
>    smb: client: fix potential deadlock when reconnecting channels
>    smb: client: fix warning when reconnecting channel
>
> Shyam Prasad N (6):
>    cifs: reset connections for all channels when reconnect requested
>    cifs: update dstaddr whenever channel iface is updated
>    cifs: dns resolution is needed only for primary channel
>    cifs: deal with the channel loading lag while picking channels
>    cifs: serialize other channels when query server interfaces is pending
>    cifs: do not disable interface polling on failure
>
>   fs/smb/client/cifsglob.h  |  3 ++
>   fs/smb/client/connect.c   | 74 ++++++++++++++++++++++++---------------
>   fs/smb/client/sess.c      |  4 +++
>   fs/smb/client/smb2pdu.c   | 37 +++++++++++++-------
>   fs/smb/client/transport.c | 14 ++++----
>   5 files changed, 84 insertions(+), 48 deletions(-)
>