NACK[O]/Cmnt: [PATCH 0/1][SRU][Unstable][Oracular] Support ov05c10 camera sensor in Intel ipu-bridge

[You-Sheng Yang]

On Fri, Jan 17, 2025 at 10:41 PM Stefan Bader
<stefan.bader at canonical.com> wrote:
>
> On 21.10.24 16:10, You-Sheng Yang wrote:
> > BugLink: https://bugs.launchpad.net/bugs/2081866
> >
> > [Impact]
> >
> > Camera sensor ov05c10 is not probed automatically:
> > ```
> > $ cat /sys/bus/acpi/devices/OVTI05C1:00/status
> > 15
> > $ sudo dmesg | grep ipu
> > ...
> > intel-ipu7 intel-ipu7: no subdev found in graph
> > intel_ipu7_psys.psys intel_ipu7.psys.40: psys probe minor: 0
> > ```
> >
> > [Fix]
> >
> > * https://github.com/intel/ipu6-drivers/blob/master/patch/v6.8/0012-media-Support-ov05c10-camera-sensor.patch
> >
> > [Test Case]
> >
> > The new camera sensor should be probed automatically and function well:
> > ```
> > $ sudo dmesg | grep ipu
> > ...
> > intel-ipu7 intel-ipu7: Found supported sensor OVTI05C1:00
> > intel-ipu7 intel-ipu7: Connected 1 cameras
> > ...
> > intel_ipu7_isys.isys intel_ipu7.isys.40: bind ov05c10 13-0010 nlanes is 2 port is 0
> > intel_ipu7_isys.isys intel_ipu7.isys.40: All sensor registration completed.
> > ```
> >
> > [Where problems could occur]
> >
> > Some of the IPU6/IPU7 camera sensor drivers are not yet upstreamed, and ov05c10
> > is one of them. Expect further turning/bug fixes.
> >
> > [Other Info]
> >
> > While ov05c10 is currently only used on Intel Lunar Lake platform with oem-6.11
> > kernel, we will target kernels >= 6.11 at least for now. Nominating for
> > Unstable-6.12, Oracular-6.11 and certainly OEM-6.11.
> >
> > Dongcheng Yan (1):
> >    UBUNTU: SAUCE: media: Support ov05c10 camera sensor
> >
> >   drivers/media/pci/intel/ipu-bridge.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> Rejected for the following reasons:
> This still is not found upstream and I doubt it will be. And since
> IPU6/7 is included as DKMS drivers it does not feel sensible to patch up
> the generic code to support it. At least not without additional
> explanations.
> -Stefan

This patch is needed even with external drivers in dkms. The
ipu-bridge must know who is on the list in order to setup a bridge for
them.

ov05c10 itself is being upstreamed by AMD:
https://lore.kernel.org/all/20250609194321.1611419-1-pratap.nirujogi@amd.com/
-- 
Regards,
You-Sheng Yang