ACK/Cmnt: [P/U] [PATCH 0/2] UBUNTU: [Packaging] two clean-ups in debian/rules

Masahiro Yamada masahiro.yamada at canonical.com
Mon Mar 3 23:00:51 UTC 2025


Hi Agathe,

On Mon, Mar 3, 2025 at 9:34 PM Agathe Porte <agathe.porte at canonical.com> wrote:
>
> 2025-03-03 11:00 CET, Masahiro Yamada:
> >
> >  - There is no need to copy $(DEBIAN)/copyright to debian/copyright.
> >    Commit debian/copyright directly
> >
> >  - Remove $(DEBIAN)/control.stub intermediate. We can do this more
> >    simply now.
> >
> >
> >
> > Masahiro Yamada (2):
> >   UBUNTU: [packaging] check-in copyright directly in debian/
> >   UBUNTU: [Packaging] remove intermediate $(DEBIAN)/control.stub
> >
> >  {debian.master => debian}/copyright |  0
> >  debian/rules                        | 22 ++++++++--------------
> >  2 files changed, 8 insertions(+), 14 deletions(-)
> >  rename {debian.master => debian}/copyright (100%)
>
> If would have appreciated comments above the .DELETE_ON_ERROR and
> .PHONY directives instead of having to rely on git blame, but this is
> personal preference.

OK, I will add comments in v2.


>
> Acked-by: Agathe Porte <agathe.porte at canonical.com>

Thanks.



More information about the kernel-team mailing list