ACK: [SRU][N][PATCH 0/1] Fix NIC name changes for ice

[Koichiro Den]

On Mon, Mar 03, 2025 at 04:26:53AM GMT, Gerald Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/2100264
> 
> [Impact]
> 
> This upstream commit introduced that Intel ice driver exports
> "phys_port_name" in sysfs interface:
> 37165e3f5664 ice: introduce VF port representor
> 
> And “phys_port_name” is used by systemd when renaming NIC,
> so when upgrading kernel from 5.15 to 6.8, this causes NIC name changes
> from ens2f0:
> kernel: ice 0000:2a:00.0 ens2f0: renamed from eth0
> to ens2f0np0:
> kernel: [ 21.217165] ice 0000:2a:00.0 ens2f0np0: renamed from eth0
> 
> In some circumstances, bond won't work after upgrading kernel because of
> its underlying NIC name changed
> 
> [Fix]
> 
> Later, upstream removed exporting "phys_port_name" in sysfs interface in
> this commit:
> 41355365d252 ice: Remove ndo_get_phys_port_name
> 
> It's removed in 6.10:
> git tag --contains 41355365d252
> v6.10
> 
> Because phys_port_name is never used, mentioned in the commit message:
> ndo_get_phys_port_name is never actually used, as in switchdev
> devlink is always being created.
> 
> We should make it consistent to not having "npX" in the tail of NIC name
> 
> [ Test ]
> 
> Install 5.15 and 6.8 kernels on a machine with Intel ice NIC and see if
> NIC name is the same.
> 
> [ Where the problems could occur ]
> 
> Since the "phys_port_name" is never actually used, it's find to remove
> it.
> 
> Dariusz Aftanski (1):
>   ice: Remove ndo_get_phys_port_name
> 
>  drivers/net/ethernet/intel/ice/ice_repr.c | 34 -----------------------
>  1 file changed, 34 deletions(-)
> 

Acked-by: Koichiro Den <koichiro.den at canonical.com>