ACK: [SRU][J:linux-bluefield][PATCH v1 0/1] mlxbf_gige: move BF2 autoneg logic out of open()
Bartlomiej Zolnierkiewicz
bartlomiej.zolnierkiewicz at canonical.com
Mon Mar 10 13:07:49 UTC 2025
On Mon, Mar 3, 2025 at 6:03 PM David Thompson <davthompson at nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2100785
>
> SRU Justification:
>
> [Impact]
>
> The mlxbf_gige driver open() method includes a segment of BF2-specific
> code that waits for autoneg completion before proceeding. The open()
> method should not pend waiting for this link up event.
>
> [Fix]
>
> The fix is to move BF2 autoneg logic out of open(), replacing it with
> logic that runs asynchronous to open() via a workqueue function.
>
> [Test Case]
>
> Boot BF2 with mlxbf_gige driver containing fix
> Verify autoneg completes, i.e. "RUNNING" status shown in "ifconfig oob_net0"
> Verify IP address is assigned to oob_net0
>
> [Regression Potential]
> Low - workqueue logic is quite simple
>
> David Thompson (1):
> UBUNTU: SAUCE: mlxbf_gige: move BF2 autoneg logic out of open()
>
> .../ethernet/mellanox/mlxbf_gige/mlxbf_gige.h | 6 ++
> .../mellanox/mlxbf_gige/mlxbf_gige_main.c | 59 +++++++++++++++----
> 2 files changed, 55 insertions(+), 10 deletions(-)
>
Acked-by: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz at canonical.com>
--
Best regards,
Bartlomiej
More information about the kernel-team
mailing list