ACK: [SRU][O/J][PATCH 0/2] ipsec_offload in rtnetlink.sh from ubunsu_kselftests_net fails on O/J (LP: #2096976)

[Massimiliano Pellizzer]

On Fri, 14 Mar 2025 at 08:58, Edoardo Canepa
<edoardo.canepa at canonical.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2096976
>
> [ Impact ]
>
> selftest: netfilter: after upstream commit 2cf567f421dbfe7e53b7e5ddee9400da10efb75d
> ipsec_offload test needs its source ip written into  the expected value, however the
> complete patchset https://lore.kernel.org/lkml/20241010040027.21440-1-liuhangbin@gmail.com/
> has a more comprehensive modification so this only fixes the test for the
> current status (only patch 2/3 of the patchset applied).
>
> Found on Oracular 6.11.0-17.17 and should be found on its derivatives /
> backports.
>
> Log output:
>
>     # selftests: net: rtnetlink.sh
>     # PASS: policy routing
>     ---(snip)---
>     # PASS: ipsec
>     # FAIL: ipsec_offload incorrect driver data
>     # FAIL: ipsec_offload
>     # PASS: bridge fdb get
>
> Verbose output should be like:
>
>     COMMAND: modprobe -q netdevsim
>     COMMAND: ip x p add dir out src 192.168.123.3/24 dst 192.168.123.4/24 tmpl
> proto esp src 192.168.123.3 dst 192.168.123.4 spi 9 mode transport reqid 42
>     COMMAND: ip x p add dir in src 192.168.123.4/24 dst 192.168.123.3/24 tmpl
> proto esp src 192.168.123.4 dst 192.168.123.3 spi 9 mode transport reqid 42
>     COMMAND: ip x s add proto esp src 192.168.123.3 dst 192.168.123.4 spi 9 mode
> transport reqid 42 aead rfc4106(gcm(aes))
> 0x3132333435363738393031323334353664636261 128 sel src 192.168.123.3/24 dst
> 192.168.123.4/24 offload dev eni0np1 dir out
>     COMMAND: ip x s add proto esp src 192.168.123.4 dst 192.168.123.3 spi 9 mode
> transport reqid 42 aead rfc4106(gcm(aes))
> 0x3132333435363738393031323334353664636261 128 sel src 192.168.123.4/24 dst
> 192.168.123.3/24 offload dev eni0np1 dir in
>     COMMAND: diff /sys/kernel/debug/netdevsim/netdevsim0/ports/0//ipsec -
>         2c2
>     < sa[0] tx ipaddr=0x00000000 00000000 00000000 047ba8c0
>     ---
>     > sa[0] tx ipaddr=0x00000000 00000000 00000000 00000000
>     FAIL: ipsec_offload incorrect driver data
>
> [ Fix ]
>
> Oracular: fixed separately
> Jammy:    fixed separately
>
> [ Test Plan ]
>
> Compiled, boot tested and auto-tested on amd64.
>
> [ Where Problems Could Occur ]
>
> The fix affects only the failing ipsec_offload of the netfilter test.
>
> --
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Massimiliano Pellizzer <massimiliano.pellizzer at canonical.com>

-- 
Massimiliano Pellizzer