ACK: [SRU][J:linux-bluefield][PATCH v1 00/14] Updates to mlxbf-pmc
Kuba Pawlak
kuba.pawlak at canonical.com
Fri Mar 21 13:29:43 UTC 2025
On 20.03.2025 07:41, Shravan Kumar Ramani wrote:
> This submission contains 14 patches. Due to issues with creating a fork and
> pull request, submitting the patches via email.
>
> This submission addresses 2 issues:
>
> 1. Replace SAUCE patches with upstream commit (Patches 1 to 13)
>
> BugLink: https://bugs.launchpad.net/bugs/2103611
>
> SRU Justification:
>
> [Impact]
> The mlxbf_pmc BlueField platform driver in the Jammy repo consists of some
> SAUCE patches. These patches need to be replaced with the corresponding
> upstream commits.
>
> [Fix]
> The fix is to revert the 3 SAUCE patches, replacing them with upstream commits
> for the same functionality. And also picking up other minor fixes to the driver
> that are upstream.
>
> [Test Case]
> * Boot BF2/BF3 platform, verify no new errors with loading the driver.
> * Test sysfs interface exposed by driver for programming various counters and
> events.
>
> [Regression Potential]
> Minimal
>
> 2. Add support for new PMC blocks (Patch 14)
>
> BugLink: https://bugs.launchpad.net/bugs/2103620
>
> SRU Justification:
>
> [Impact]
> Some PMC blocks such as APT, EMI, GGA, MSN and PRNF are not currently supported
> by the driver.
>
> [Fix]
> Add support for APT, EMI, GGA, MSN and PRNF counters and the respective events
> supported by each of them. The driver creates new sub-directories for each block
> in the hwmonN directory.
>
> [Test Case]
> Read the list of supported events for each block via the event_list file.
> Then program any counter by writing the event number (from the list of events
> in event_list) to eventN file, and start the counters by writing 1 to enable.
> Then, stop the counters after a while by writing 0 to enable and read the
> counter value from counterN file.
>
> [Regression Potential]
> Can be considered minimal since it uses the same mechanism as the existing
> blocks.
>
> Dan Carpenter (1):
> platform/mellanox: mlxbf-pmc: fix signedness bugs
>
> Luiz Capitulino (3):
> platform/mellanox: mlxbf-pmc: mlxbf_pmc_event_list(): make size ptr
> optional
> platform/mellanox: mlxbf-pmc: Ignore unsupported performance blocks
> platform/mellanox: mlxbf-pmc: fix lockdep warning
>
> Pei Xiao (1):
> platform/mellanox: mlxbf-pmc: incorrect type in assignment
>
> Shravan Kumar Ramani (9):
> Revert "UBUNTU: SAUCE: mlxbf-pmc: Fix offset calculation for crspace
> events"
> Revert "UBUNTU: SAUCE: mlxbf-pmc: Add support for clock_measure
> performance block"
> Revert "UBUNTU: SAUCE: mlxbf-pmc: Add support for 64-bit counters and
> cycle count"
> platform/mellanox: mlxbf-pmc: Fix offset calculation for crspace
> events
> platform/mellanox: mlxbf-pmc: Replace uintN_t with kernel-style types
> platform/mellanox: mlxbf-pmc: Cleanup signed/unsigned mix-up
> platform/mellanox: mlxbf-pmc: Add support for monitoring cycle count
> platform/mellanox: mlxbf-pmc: Add support for clock_measure
> performance block
> UBUNTU: SAUCE: platform/mellanox: mlxbf-pmc: Support additional PMC
> blocks
>
> drivers/platform/mellanox/mlxbf-pmc.c | 530 +++++++++++++++-----------
> 1 file changed, 312 insertions(+), 218 deletions(-)
>
Acked-by: Kuba Pawlak <kuba.pawlak at canonical.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0x216A9D7E3B63DCB4.asc
Type: application/pgp-keys
Size: 3139 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250321/76892a43/attachment.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250321/76892a43/attachment.sig>
More information about the kernel-team
mailing list