ACK/Cmnt: [SRU][J:linux-bluefield][PATCH v3 0/9] revert SAUCE patches for mlxbf-tmfifo driver

[Bartlomiej Zolnierkiewicz]

On Mon, Mar 24, 2025 at 3:00 AM Haifei Luo <haifeil at nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2103386
>
> SRU Justification
>
> [Description]
> The following SAUCE patches should be reverted and replaced with upstream commits:
> 7789adb5fe90 UBUNTU: SAUCE: mlxbf-tmfifo: fix potential race
> 3d8185022ec5 UBUNTU: SAUCE: platform/mellanox: mlxbf-tmfifo: Add BlueField-3 support
>
> [Impact]
> Align with upstream commits.
>
> [Fix]
> Other two commits are depended on the commits and need reverted. The reverted commits are:
> fe4595c4d14e platform/mellanox: mlxbf-tmfifo: Drop Tx network packet when Tx TmFIFO is full
> 7789adb5fe90 UBUNTU: SAUCE: mlxbf-tmfifo: fix potential race
> 3d77627b0ada UBUNTU: SAUCE: platform/mellanox: Add ctrl message and MAC configuration
> 3d8185022ec5 UBUNTU: SAUCE: platform/mellanox: mlxbf-tmfifo: Add BlueField-3 support
>
> Upstream ones are using ACPI API and this one should be cherry-picked too.
> 5db72fd ACPI: utils: Add acpi_dev_uid_to_integer() helper to get _UID as integer
>
> [Test Case]
> 1. Get the iperf data with current mlxbf_tmfifo module.
> 2. Unload mlxbf_tmfifo and load the newly built module. Get the iperf data.
> 3. Make sure it works and no performance degradation.
>
> Andy Shevchenko (1):
>   ACPI: utils: Add acpi_dev_uid_to_integer() helper to get _UID as
>     integer
>
> Haifei Luo (4):
>   Revert "platform/mellanox: mlxbf-tmfifo: Drop Tx network packet when
>     Tx TmFIFO is full"
>   Revert "UBUNTU: SAUCE: mlxbf-tmfifo: fix potential race"
>   Revert "UBUNTU: SAUCE: platform/mellanox: Add ctrl message and MAC
>     configuration"
>   Revert "UBUNTU: SAUCE: platform/mellanox: mlxbf-tmfifo: Add
>     BlueField-3 support"
>
> Liming Sun (4):
>   platform/mellanox: Add BlueField-3 support in the tmfifo driver
>   UBUNTU: SAUCE: platform/mellanox: Add ctrl message and MAC
>     configuration
>   platform/mellanox: fix potential race in mlxbf-tmfifo driver
>   platform/mellanox: mlxbf-tmfifo: Drop Tx network packet when Tx TmFIFO
>     is full
>
>  drivers/acpi/utils.c                          |  24 ++++
>  drivers/platform/mellanox/mlxbf-tmfifo-regs.h |  16 +--
>  drivers/platform/mellanox/mlxbf-tmfifo.c      | 107 +++++++++---------
>  include/acpi/acpi_bus.h                       |   1 +
>  include/linux/acpi.h                          |   5 +
>  5 files changed, 92 insertions(+), 61 deletions(-)
>

I see two minor issues:
- Change-Id shouldn't be present in the patch descriptions
- patches #7 and #9 should use the current BugLink not the old ones
but both issues can be fixed while applying this patchset so:

Acked-by: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz at canonical.com>

--
Best regards,
Bartlomiej